Project

General

Profile

Bug #13695

Issue with require and require_relative with symlinked directories

Added by fidothe (Matt Patterson) 5 months ago. Updated 5 months ago.

Status:
Open
Priority:
Normal
Assignee:
-
Target version:
-
ruby -v:
ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-darwin16]
[ruby-core:81819]

Description

Symlinked directories cause an issue with require_relative where libraries loaded from a symlinked path (e.g. in a typical Capistrano / Bundler deployment) can be double-loaded.

Reproduce process:

  1. Clone git repo from https://github.com/fidothe/symlink-require
  2. Run use-symlink.rb script:
$ ruby use-symlink.rb

Expected result: No warning from double-loading of constants issued.
Actual result: double-loading of file causing already-initialised constant warning.

In the example I linked above, target.rb uses require_relative to load dependent.rb.

When the example also requires dependent.rb the file is double-loaded and we see a warning about already-initialized constant.

The problem is that when require in use-symlink.rb (line 7) checks the set of loaded files it uses an absolute path containing the symlink (since that is what was added to $LOAD_PATH), but when require_relative in target.rb is called, it uses an absolute path containing target of the symlink, causing the double-load.

Is this discrepancy intended behaviour on Ruby's part?

History

#1 [ruby-core:81820] Updated by rrosenblum (Ryan Rosenblum) 5 months ago

rspec-duplicate-require shows that this behavior has been around for at least 4 years. More recent discussions of this have been going on in prawn and pdf-core.

#2 [ruby-core:81822] Updated by shyouhei (Shyouhei Urabe) 5 months ago

I guess this is a dup of #10222.

#3 [ruby-core:81827] Updated by fidothe (Matt Patterson) 5 months ago

shyouhei (Shyouhei Urabe) wrote:

I guess this is a dup of #10222.

It is, sorry for not finding that when I looked for existing issues related to this.

Also available in: Atom PDF