Actions
Misc #13702
closedTZ checking in rb_w32_fstati64()
Status:
Closed
Assignee:
Description
The environment variable TZ is checked in rb_w32_fstati64().
https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/59061/entry/win32/win32.c#L5417
This was added in r48394 to make File#stat faster. I guess that
it was added not to call GetFileInformationByHandle() when TZ isn't set.
But the effect has turned off since r50870 because it calls
GetFileInformationByHandle() even when TZ isn't set.
As a result, the TZ checking in rb_w32_fstati64() is meaningless now.
IMO, the following lines could be removed without side effects.
- if-clause in rb_w32_fstati64() (line 5417-5421 in win32/win32.c)
- stati64_set_inode_handle() (line 5379-5390 in win32/win32.c)
Actions
Like0
Like0Like0Like0Like0