Project

General

Profile

Bug #13843

[PATCH] RubyGems 2.6.13 - Align lib/rubygems/resolver.rb with rubygems/rubygems

Added by MSP-Greg (Greg L) 3 months ago. Updated about 1 month ago.

Status:
Rejected
Priority:
Normal
Target version:
-
ruby -v:
ruby 2.5.0dev (2017-08-25 trunk 59654) [x64-mingw32]
[ruby-core:82487]

Description

Currently, the file lib/rubygems/resolver.rb differs between ruby/ruby and rubygems/rubygems in the search_for method.

Attached patch aligns them and adds the test for it, which is also missing from ruby/ruby. Tested against MinGW trunk builds and Travis.

See rubygem/rubygems PR 1993

gem_resolver.patch (2.46 KB) gem_resolver.patch MSP-Greg (Greg L), 08/28/2017 01:25 PM

History

#1 Updated by MSP-Greg (Greg L) 3 months ago

  • Subject changed from RubyGems 2.6.13 - Align lib/rubygems/resolver.rb with rubygems/rubygems to [PATCH} RubyGems 2.6.13 - Align lib/rubygems/resolver.rb with rubygems/rubygems

#2 Updated by MSP-Greg (Greg L) 3 months ago

  • Subject changed from [PATCH} RubyGems 2.6.13 - Align lib/rubygems/resolver.rb with rubygems/rubygems to [PATCH] RubyGems 2.6.13 - Align lib/rubygems/resolver.rb with rubygems/rubygems

#3 [ruby-core:82489] Updated by MSP-Greg (Greg L) 3 months ago

At rubygems/rubygems, the patch for resolver.rb was accepted first, then the patch to extend appveyor testing to include trunk was accepted.

Appveyor results and Travis results.

Sorry if I'm being a PITA, but since I'm testing a lot these days, the idea that a trunk build from last week (gem -v 2.6.12) which had a gem update --system done would have different code than a current build (gem -v 2.6.13) is not another vector/dimension I want present in things to keep track of...

#4 [ruby-core:82503] Updated by hsbt (Hiroshi SHIBATA) 3 months ago

  • Assignee set to hsbt (Hiroshi SHIBATA)
  • Status changed from Open to Assigned

#5 [ruby-core:83226] Updated by hsbt (Hiroshi SHIBATA) about 1 month ago

  • Backport changed from 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN to 2.2: DONTNEED, 2.3: DONTNEED, 2.4: DONTNEED
  • Status changed from Assigned to Rejected

It's already merged into Rubygems master. we will merge this on Ruby 2.5.0.

Also available in: Atom PDF