Actions
Bug #13940
closedem-http-request (HttpConnectionOptions) over-write :sni_hostname if provided
Status:
Third Party's Issue
Assignee:
-
Target version:
-
ruby -v:
ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-darwin16]
Description
Breaking change introduced in 1.1.4
http_connnection_options.rb:23
@tls[:sni_hostname] = ori.host
This OVER-write the sni_hostname value which MAY have been passed in.
Suggested Change to SET sni_hostname ONLY IF not provided¶
@tls[:sni_hostname] ||= uri.host
Updated by naruse (Yui NARUSE) over 6 years ago
- Status changed from Open to Rejected
We CRuby project doesn't handle em-http-request.
Could you ask on https://github.com/igrigorik/em-http-request ?
Updated by shyouhei (Shyouhei Urabe) over 6 years ago
- Status changed from Rejected to Third Party's Issue
Actions
Like0
Like0Like0