Project

General

Profile

Actions

Bug #14027

closed

Ripper parses squiggly heredoc incorrectly

Added by mjago (Martyn Jago) over 6 years ago. Updated over 6 years ago.

Status:
Closed
Assignee:
-
Target version:
-
ruby -v:
ruby 2.5.0dev (2017-10-18 trunk 60205) [x86_64-darwin13]
[ruby-core:83343]

Description

Where you have two or more embedded expressions on the same line within a squiggly heredoc
seperated by whitespace, Ripper considers that whitespace as ignored space despite it not being at the
beginning of a line. Below is a diff of lexer output between identical heredoc and squiggly heredoc to highlight:

-[[[1, 0], :on_heredoc_beg, "<<-E", EXPR_BEG],
+[[[1, 0], :on_heredoc_beg, "<<~E", EXPR_BEG],
  [[1, 4], :on_nl, "\n", EXPR_BEG],
  [[2, 0], :on_embexpr_beg, "\#{", EXPR_BEG],
  [[2, 2], :on_int, "1", EXPR_END|EXPR_ENDARG],
  [[2, 3], :on_embexpr_end, "}", EXPR_END],
- [[2, 4], :on_tstring_content, " ", EXPR_BEG],
+ [[2, 4], :on_ignored_sp, " ", EXPR_BEG],
  [[2, 5], :on_embexpr_beg, "\#{", EXPR_BEG],
  [[2, 7], :on_int, "2", EXPR_END|EXPR_ENDARG],
  [[2, 8], :on_embexpr_end, "}", EXPR_END],
  [[2, 9], :on_tstring_content, "\n", EXPR_BEG],
  [[3, 0], :on_heredoc_end, "E", EXPR_BEG]]

Also the sexp shows the whitespace as an empty string:

[:program,
  [[:string_literal,
    [:string_content,
     [:string_embexpr, [[:@int, "1", [2, 2]]]],
-    [:@tstring_content, " ", [2, 4]],
+    [:@tstring_content, "", [2, 5]],
     [:string_embexpr, [[:@int, "2", [2, 7]]]],
     [:@tstring_content, "\n", [2, 9]]]]]]

This can be seen on head, 2.4.2, and 2.3.5

Scripts used:

ruby -rripper -rpp -e '%{<<-E\n\#{1} \#{2}\nE}'
ruby -rripper -rpp -e '%{<<~E\n\#{1} \#{2}\nE}'
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0