Bug #15466: test_self_install_permissions tests fail when compiled with --program-suffix

• Status: Third Party's Issue
• Assignee: hsbt (Hiroshi SHIBATA)
• Target version: -
• ruby -v: ruby 2.6.0p0 (2018-12-25 revision 66547) [x86_64-linux]
• Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN

[johnl (John Leach)]

compiling ruby 2.6.0p0 with --program-suffix=2.6 causes 3 tests to fail:

  1) Error:
TestGem#test_self_install_permissions_umask_077:
Errno::ENOENT: No such file or directory @ rb_file_s_stat - bin/foo.cmd2.6
    test/rubygems/test_gem.rb:196:in `stat'
    test/rubygems/test_gem.rb:196:in `block (2 levels) in assert_self_install_permissions'
    test/rubygems/test_gem.rb:195:in `each_key'
    test/rubygems/test_gem.rb:195:in `block in assert_self_install_permissions'
    test/rubygems/test_gem.rb:194:in `chdir'
    test/rubygems/test_gem.rb:194:in `assert_self_install_permissions'
    test/rubygems/test_gem.rb:148:in `test_self_install_permissions_umask_077'

  2) Error:
TestGem#test_self_install_permissions_umask_0:
Errno::ENOENT: No such file or directory @ rb_file_s_stat - bin/foo.cmd2.6
    test/rubygems/test_gem.rb:196:in `stat'
    test/rubygems/test_gem.rb:196:in `block (2 levels) in assert_self_install_permissions'
    test/rubygems/test_gem.rb:195:in `each_key'
    test/rubygems/test_gem.rb:195:in `block in assert_self_install_permissions'
    test/rubygems/test_gem.rb:194:in `chdir'
    test/rubygems/test_gem.rb:194:in `assert_self_install_permissions'
    test/rubygems/test_gem.rb:141:in `test_self_install_permissions_umask_0'

  3) Error:
TestGem#test_self_install_permissions:
Errno::ENOENT: No such file or directory @ rb_file_s_stat - bin/foo.cmd2.6
    test/rubygems/test_gem.rb:196:in `stat'
    test/rubygems/test_gem.rb:196:in `block (2 levels) in assert_self_install_permissions'
    test/rubygems/test_gem.rb:195:in `each_key'
    test/rubygems/test_gem.rb:195:in `block in assert_self_install_permissions'
    test/rubygems/test_gem.rb:194:in `chdir'
    test/rubygems/test_gem.rb:194:in `assert_self_install_permissions'
    test/rubygems/test_gem.rb:136:in `test_self_install_permissions'

the installed file is actually called bin/foo.cmd on disk, so is missing the expected prefix.

These tests were changed to test for this 9 days ago: https://github.com/rubygems/rubygems/pull/2529

My understanding is that rubygems only adds the suffix to gem commands if you explicitly use the --format-executable option.

So I'm not sure whether the tests are broken or the actual behaviour is broken.

[hsbt (Hiroshi SHIBATA)]

• Status changed from Open to Assigned

[hsbt (Hiroshi SHIBATA)]

• Status changed from Assigned to Third Party's Issue
• Assignee set to hsbt (Hiroshi SHIBATA)

We will fix this issue at https://github.com/rubygems/rubygems/pull/2549