Project

General

Profile

Feature #16404

Add Proc#ruby2_keywords

Added by jeremyevans0 (Jeremy Evans) 8 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-core:96122]

Description

While the need is not as common as for methods, procs could benefit from supporting ruby2_keywords, and there are cases in Rails where keywords are passed through procs using a normal argument splat [1]. If we don't add this, such cases will require separate proc definitions depending on ruby version. With this, you only need to call ruby2_keywords on the proc if it is defined. Example:

foo = ->(*args, &block){block.call(*args)}
foo.call(a: 1,  &->(**x){x})
# warning: The last argument is used as the keyword parameter
# warning: for `call' defined here; maybe ** should be added to the call?
# => {:a=>1}

foo.ruby2_keywords
foo.call(a: 1,  &->(**x){x})
# => {:a=>1}

I've added a pull request for this: https://github.com/ruby/ruby/pull/2728

[1] https://github.com/rails/rails/blob/34d66ca6bab109540299a7b30980627bea37e323/activemodel/lib/active_model/type/registry.rb#L12

Updated by matz (Yukihiro Matsumoto) 8 months ago

It is ugly, and I personally don't want to add it to the language. But I have to admit it solves the real-world issues in some cases. So I accept. This might be removed sometime in Ruby3.x (after proper deprecation process).

Matz.

Updated by jeremyevans0 (Jeremy Evans) 8 months ago

  • Status changed from Open to Closed

Also available in: Atom PDF