Project

General

Profile

Actions
Copy link

Bug #17202

closed

Backport for Apple Silicon

Added by hsbt (Hiroshi SHIBATA) over 3 years ago. Updated over 2 years ago.

Status:
Closed
Assignee:
-
Target version:
-
ruby -v:
Backport:
2.5: UNKNOWN, 2.6: REQUIRED, 2.7: DONE
[ruby-core:100211]

Description

I confirmed to build with the following patch on ruby_2_7 branch for macOS Big Sur and ARM mac mini.

https://github.com/ruby/ruby/commit/23655e6de5ee989feb8c65c7061fe9a71579dc54
https://github.com/ruby/ruby/commit/87f6154bb4c67ca77ee353bb1fe25a922036c0e5

Actions
Copy link
 #1 [ruby-core:100212]

Updated by hsbt (Hiroshi SHIBATA) over 3 years ago

  • Backport changed from 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: REQUIRED to 2.5: UNKNOWN, 2.6: REQUIRED, 2.7: REQUIRED

I also confirmed to build the following patch and https://github.com/ruby/ruby/commit/87f6154bb4c67ca77ee353bb1fe25a922036c0e5 on ruby_2_6 branch.

diff --git a/configure.ac b/configure.ac
index 2c4d2888d2..e9bf833668 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2319,6 +2319,9 @@ AS_CASE(["$rb_cv_fiber_coroutine"], [yes|''], [
        [x*64-darwin*], [
            rb_cv_fiber_coroutine=amd64
        ],
+       [arm64-darwin*], [
+           rb_cv_coroutine=arm64
+        ],
        [x*64-linux], [
            AS_CASE(["$ac_cv_sizeof_voidp"],
                [8], [ rb_cv_fiber_coroutine=amd64 ],
Actions
Copy link
 #3 [ruby-core:100233]

Updated by nagachika (Tomoyuki Chikanaga) over 3 years ago

  • Backport changed from 2.5: UNKNOWN, 2.6: REQUIRED, 2.7: REQUIRED to 2.5: UNKNOWN, 2.6: REQUIRED, 2.7: DONE

ruby_2_7 f46929833923d96e4dc706945fd537a1caaebe66 merged revision(s) f96216df8dfd2d1e206150572912289f4dda7386,0091fac1d8de07e86fef8315ba77609bed9dd7f5,04c704c5c967ea9bded6bf645439fe59c7d9f7d6,23655e6de5ee989feb8c65c7061fe9a71579dc54,7cb8904a12c850ee30dcd67817fa2f9dc3fee813,41168f69fbeb32cfc88210911d62e419b8116589,87f6154bb4c67ca77ee353bb1fe25a922036c0e5.

Actions
Copy link
 #4 [ruby-core:100234]

Updated by nagachika (Tomoyuki Chikanaga) over 3 years ago

... and f96216df8dfd2d1e206150572912289f4dda7386, 0091fac1d8de07e86fef8315ba77609bed9dd7f5, 04c704c5c967ea9bded6bf645439fe59c7d9f7d6 too.

Actions
Copy link
 #5 [ruby-core:100244]

Updated by nagachika (Tomoyuki Chikanaga) over 3 years ago

... and backported d732bc51bdbfe7d66038731d42e01a511d13b5f8,633a1f15d8228236094ddee12e4e169d655ec49e,95f387f61a4a4ea92635da760b7de5b1e09bb84e,528a3a17977aa1843a26630c96635c3cb161e729,261569d4aac440f25de588cca365163ecf1124a2,e4a9e926f0fe0acf2fbe61da6e075a95d34be066,318be1cb2f9c6f04403c063a5618c6267012ee51,e1855100e46040e73630b378974c17764e0cccee,9cfa811b0f209d714f89fe0de6778c71f77556c7,b68dab866724aacc1cbc6b7d5e1f555dec092346 too.
These seems necessary to fix CI error on CentOS/RHEL/fedra environments.

Actions
Copy link
 #7 [ruby-core:100255]

Updated by nagachika (Tomoyuki Chikanaga) over 3 years ago

backported 0168094da28c146062db22e69cbd9316418310f9,cdef17096c03099f17ecf0af51f43faa0944f96d,b7d86e330c76b4f9615511307e1c40f4f2937c83 into ruby_2_7 at 5445e0435260b449decf2ac16f9d09bae3cafe72.

Actions
Copy link
 #8 [ruby-core:104985]

Updated by znz (Kazuhiro NISHIYAMA) over 2 years ago

CI of snapshot-ruby_2_6 failed on macos-11.
It seems this issue is related.
Because nobu says
https://github.com/ruby/ruby/commit/cdef17096c03099f17ecf0af51f43faa0944f96d and
https://github.com/ruby/ruby/commit/b7d86e330c76b4f9615511307e1c40f4f2937c83 are related.
And backport property includes 2.6: REQUIRED.

https://github.com/ruby/actions/runs/3364501064?check_suite_focus=true#step:17:191

/Users/runner/work/actions/actions/snapshot-ruby_2_6/test/fiddle/helper.rb:100:in ``': No such file or directory - ldd (Errno::ENOENT)
Actions
Copy link

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0Like0Like0