Project

General

Profile

Actions

Feature #17682

open

String#casecmp performance improvement

Added by Dan0042 (Daniel DeLorme) 7 months ago. Updated 6 months ago.

Status:
Open
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-core:102791]

Description

I've submitted a PR with up to 27x speedup for String#casecmp: https://github.com/ruby/ruby/pull/4133
According to HowToContribute it looks like I was supposed to create a ticket for "non-tiny" fixes so I'm now doing this.

One point of discussion is that I added a flag for ascii-safe encodings (which is different from ascii-compatible) but I'm not sure hardcoding this list in enc_register_at is the correct way to do this. I just didn't see how else. So I'd appreciate some comments/guidance on this. Thank you.

Also I didn't find anything in the wiki about naming conventions so I just went by gut feeling. So there may be functions/macros to rename to be more in line with the rest of the codebase.

Actions

Also available in: Atom PDF