Bug #18237: Remove unnecessary checks for `Time` in `Range#each` as per the comment

• Status: Closed
• Assignee: -
• Target version: -
• ruby -v: ruby 3.1.0dev (2021-10-03T09:41:29Z master bf4f3ef5ad) [x86_64-darwin19]
• Backport: 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN

[jwmittag (Jörg W Mittag)]

In 7817a438eb1803e7b3358f43bd1f38479badfbdc, the implementation of Time#succ, which had been deprecated for 10 years, was finally removed.

During that time, there was an explicit instance_of? check in source:range.c#L350 with a comment that the check should be removed once Time#succ is removed.

Since Time#succ is now gone, I propose removing this check.

Note: this should be coordinated with adding a version guard to the corresponding check in ruby/spec as well.

See the following pull requests for details:

• YARV GitHub Pull Request 4928
• ruby/spec GitHub Pull Request 852

Patches are also attached.

[jwmittag (Jörg W Mittag)]

• Description updated (diff)

[jwmittag (Jörg W Mittag)]

• File Remove-unnecessary-checks-in-Range-each-Bug-18237.patch Remove-unnecessary-checks-in-Range-each-Bug-18237.patch added
• Description updated (diff)

[jwmittag (Jörg W Mittag)]

• Description updated (diff)
• File Remove-unnecessary-checks-in-Range-each-spec-Bug-18237.patch Remove-unnecessary-checks-in-Range-each-spec-Bug-18237.patch added

• Status changed from Open to Closed

Applied in changeset git|fb03598666ddbb9f8b35eb4f599e75654ca7ca06.

---

Remove unnecessary checks in Range#each [Bug #18237]

In 7817a438eb1803e7b3358f43bd1f38479badfbdc, the implementation
of Time#succ, which had been deprecated for 10 years, was finally
removed.

During that time, there was an explicit instance_of? check in
source:range.c#L350 with a comment that the check should be removed
once Time#succ is removed.

Since Time#succ is now gone, this check should be removed.

Note: this should be coordinated with adding a version guard to the
corresponding check in ruby/spec as well.