Bug #18906
closed
GitHub Actions log will expire, so I copy and paste it.
https://github.com/ruby/actions/runs/6857369382?check_suite_focus=true#step:9:84
test-tool
Run options:
--seed=60580
"--ruby=./miniruby -I./lib -I. -I.ext/common ./tool/runruby.rb --extout=.ext -- --disable-gems"
# Running tests:
1) Error:
TestHtgroup#test_htgroup:
RangeError: integer 21320232894293 too big to convert to `int'
/home/runner/work/actions/actions/ruby/tool/lib/webrick/httpauth/htgroup.rb:76:in `flush'
/home/runner/work/actions/actions/ruby/tool/test/webrick/test_htgroup.rb:12:in `block in test_htgroup'
/home/runner/work/actions/actions/ruby/lib/tempfile.rb:407:in `create'
/home/runner/work/actions/actions/ruby/tool/test/webrick/test_htgroup.rb:7:in `test_htgroup'
Finished tests in 9.703101s, 31.4333 tests/s, 180.7670 assertions/s.
305 tests, 1754 assertions, 0 failures, 1 errors, 12 skips
ruby -v: ruby 3.2.0dev (2022-06-13T06:22:32Z master b2e58b02ae) [x86_64-linux]
Coverage report generated for Ruby's `make test-all` to /home/runner/work/actions/actions/ruby/coverage. 6431 / 11466 LOC (56.09%) covered.
make: *** [uncommon.mk:810: yes-test-tool] Error 1
Error: Process completed with exit code 2.
- Status changed from Open to Closed
Applied in changeset git|a871fc4d86e857b4c580604d2654877135484896.
Fix a regression of b2e58b02aec73f9c350bf109c021c180fc699ccc
At that commit, I fixed a wrong conditional expression that was always
true. However, that seemed to have caused a regression. [Bug #18906]
This change removes the condition to make the code always enabled.
It had been enabled until that commit, albeit unintentionally, and even
if it is enabled it only consumes a tiny bit of memory, so I believe it
is harmless. [Bug #18906]
Also available in: Atom
PDF
Like0
Like0Like0Like0