Project

General

Profile

Actions

Bug #19447

closed

Merge `internal/rgengc.h` into public `internal/gc.h` header

Added by eightbitraptor (Matthew Valentine-House) over 1 year ago. Updated about 1 year ago.

Status:
Closed
Assignee:
-
Target version:
-
[ruby-core:112475]

Description

[Github PR #7310]

This PR merges the rgengc.h internal header into the public internal gc.h header.

rgengc.h was introduced as part of this commit 9e6e39c3512f7a962c44dc3729c98a0f8be90341 when ruby.h was split apart. It mostly contains macros for enabling the write barrier on objects,

I have merged this into include/ruby/internal/gc.h in order to keep the internal GC api spread across as few places as possible.

I don't believe that this will cause a problem with C extensions despite the removal of a public header file. Both include/ruby/internal/rgengc.h and include/ruby/internal/gc.h were both included from ruby/ruby.h and so every C extension that #include <ruby/ruby.h> already has access to their definitions.

I think that the only case there would be a problem is if a user had explicitly #include <ruby/internal/rgengc.h> which is unneccesary if they've already included <ruby/ruby.h>.

Updated by tenderlovemaking (Aaron Patterson) about 1 year ago

  • Status changed from Open to Closed

I merged the PR. Thank you!

Actions

Also available in: Atom PDF

Like1
Like0