Project

General

Profile

Actions

Bug #19546

closed

IO::Buffer is incorrectly invoking fiber scheduler interface.

Added by ioquatix (Samuel Williams) about 1 year ago. Updated 10 months ago.


Description

(Original bug report: https://github.com/socketry/async/issues/224)

The IO::Buffer implementation incorrectly calls rb_fiber_scheduler_io_write with the size_ts converted to VALUEs: https://github.com/ruby/ruby/blob/400ccb16eefe4e21c4e3eacab4fd0f208fc5e151/io_buffer.c#L2607

But that function expects size_ts: https://github.com/ruby/ruby/blob/400ccb16eefe4e21c4e3eacab4fd0f208fc5e151/scheduler.c#L542

(And probably the same for the other scheduler methods + data types.)

Fixed by https://github.com/ruby/ruby/pull/7593.

Actions #1

Updated by ioquatix (Samuel Williams) about 1 year ago

  • Description updated (diff)
Actions #2

Updated by ioquatix (Samuel Williams) about 1 year ago

  • Description updated (diff)

Updated by ioquatix (Samuel Williams) about 1 year ago

  • Backport changed from 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN to 2.7: DONTNEED, 3.0: DONTNEED, 3.1: DONTNEED, 3.2: REQUIRED
Actions #4

Updated by ioquatix (Samuel Williams) about 1 year ago

  • Status changed from Open to Closed

Updated by nagachika (Tomoyuki Chikanaga) 10 months ago

  • Backport changed from 2.7: DONTNEED, 3.0: DONTNEED, 3.1: DONTNEED, 3.2: REQUIRED to 2.7: DONTNEED, 3.0: DONTNEED, 3.1: DONTNEED, 3.2: DONE

ruby_3_2 5ad2390b551f4a28ea3d4db78c21863489fdd681 merged revision(s) 466aa8010fb49f9ec6c78ea1de4e8ca0965f4fdf.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0