Bug #20198: Threaded DNS resolver does not propagate errno to the calling thread

• Status: Closed
• Assignee: kjtsanaktsidis (KJ Tsanaktsidis)
• Target version: -
• Backport: 3.0: DONTNEED, 3.1: DONTNEED, 3.2: DONTNEED, 3.3: DONE

[kjtsanaktsidis (KJ Tsanaktsidis)]

If we get a return value of EAI_SYSTEM from getaddrinfo, we transform that into an appropriate Errno:: exception on the Ruby side. However, because we now run the actual call to getaddrinfo in a thread, we lose that errno value (because errno is thread-local). So, what we actually raise in case of EAI_SYSTEM is just the last error which happened on the calling thread - e.g. this ECHILD which presumably got set in the bowels of pthreads somewhere:

   1)
  Socket::IPSocket#getaddress raises an error on unknown hostnames ERROR
  Expected SocketError
  but got: Errno::ECHILD (No child processes - getaddrinfo)
  /home/runner/work/ruby/ruby/src/spec/ruby/library/socket/ipsocket/getaddress_spec.rb:22:in `getaddress'
  /home/runner/work/ruby/ruby/src/spec/ruby/library/socket/ipsocket/getaddress_spec.rb:22:in `block (3 levels) in <top (required)>'
  /home/runner/work/ruby/ruby/src/spec/ruby/library/socket/ipsocket/getaddress_spec.rb:21:in `block (2 levels) in <top (required)>'
  /home/runner/work/ruby/ruby/src/spec/ruby/library/socket/ipsocket/getaddress_spec.rb:4:in `<top (required)>'

[kjtsanaktsidis (KJ Tsanaktsidis)]

https://github.com/ruby/ruby/pull/9628 will fix this.

[kjtsanaktsidis (KJ Tsanaktsidis)]

• Status changed from Open to Closed
• Backport changed from 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN to 3.0: DONTNEED, 3.1: DONTNEED, 3.2: DONTNEED, 3.3: REQUIRED

Fix in the above PR was merged.

[naruse (Yui NARUSE)]

• Backport changed from 3.0: DONTNEED, 3.1: DONTNEED, 3.2: DONTNEED, 3.3: REQUIRED to 3.0: DONTNEED, 3.1: DONTNEED, 3.2: DONTNEED, 3.3: DONE

ruby_3_3 a889304fed63c3206f27d614ab75219271fb4ca9 merged revision(s) 6c0e58a54e3fda604386d9c409e2a9998bbc9352.