Project

General

Profile

Actions

Bug #20607

open

Exception messages are inconsistent when thread-local variables are accessed

Added by andrykonchin (Andrew Konchin) 10 days ago. Updated 10 days ago.

Status:
Open
Assignee:
-
Target version:
-
[ruby-core:118432]

Description

Thread's methods to manipulate thread-local variables raise TypeError exceptions with slightly different messages when the key argument is not a String or a Symbol. The message is either is not a symbol or is not a symbol nor a string. As far as both String and Symbol arguments are correct it seems the is not a symbol nor a string message is more accurate and should be used consistently.

The following methods raise is not a symbol error:

@t.thread_variable_set(:a, 0) # for some methods it's important to have some thread-local variables assigned

@t.thread_variable_get(123) # => 123 is not a symbol (TypeError)
t.thread_variable_set(123, 1) # => 123 is not a symbol (TypeError)
t.thread_variable?(123) # => 123 is not a symbol (TypeError)
t[123] = 1 # => 123 is not a symbol (TypeError)

The following methods raise is not a symbol nor a string error:

t.fetch(123) # => 123 is not a symbol nor a string (TypeError)
t.key?(123) # => 123 is not a symbol nor a string (TypeError)
t[123] # => 123 is not a symbol nor a string (TypeError)

Updated by jeremyevans0 (Jeremy Evans) 10 days ago

I submitted a pull request to make the error message consistent: https://github.com/ruby/ruby/pull/11097

Actions

Also available in: Atom PDF

Like0
Like1