Bug #20985: Undefined constant in net/http

• Status: Closed
• Assignee: -
• Target version: -
• ruby -v: ruby 3.3.6 (2024-11-05 revision 75015d4c1f) [amd64-freebsd14]
• Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN, 3.4: UNKNOWN

[BertramScharpf (Bertram Scharpf)]

$ grep -rnH HTTPAuthenticationError /usr/local/lib/ruby
/usr/local/lib/ruby/site_ruby/3.3/rubygems/vendor/net-http/lib/net/http.rb:2455:      raise HTTPAuthenticationError.new('HTTP authentication failed', err)
/usr/local/lib/ruby/3.3/net/http.rb:2455:      raise HTTPAuthenticationError.new('HTTP authentication failed', err)
/usr/local/lib/ruby/3.3/rubygems/vendor/net-http/lib/net/http.rb:2455:      raise HTTPAuthenticationError.new('HTTP authentication failed', err)

$ ruby -r net/http -e 'HTTPAuthenticationError'
-e:1:in `<main>': uninitialized constant HTTPAuthenticationError (NameError)

HTTPAuthenticationError
^^^^^^^^^^^^^^^^^^^^^^^

The raise statement will just transform a meaningful error into a NameError.

[nobu (Nobuyoshi Nakada)]

• Description updated (diff)

This constant was introduced in ae2c8b45d2c345faea6a7f2203603b4862f3a66c, but has never existed then or since.
Although we cannot guess the author's intention, the rescue clause looks able to be removed safely.

Could you report it to the upstream, https://github.com/ruby/net-http?

[BertramScharpf (Bertram Scharpf)]

nobu (Nobuyoshi Nakada) wrote in #note-1:

Could you report it to the upstream, https://github.com/ruby/net-http?

Sorry, no. For just removing two lines of code, this report should suffice.
The net-http project currently has 16 open pull requests and 30 open issues;
the oldest one waits for almost 4 years to be answered. I have better things
to do than being ignored by those people.

Besides that, I do not want to be involved in projects that show up such
ridiculous flaws.

[hsbt (Hiroshi SHIBATA)]

• Status changed from Open to Closed

We should handle this on https://github.com/ruby/net-http.