Actions
Bug #22084
closed
invokesuper from define_method in Ractor can call wrong super method or crash
Bug #22084:
invokesuper from define_method in Ractor can call wrong super method or crash
Description
vm_search_super_method has an odd behaviour where it allocates new callinfo (ci) and assigns it back to the iseq. All of our other method calls only reassign the callcache (cc). Because this CI is used from the iseq immediately after for method lookup or even later for the name in method_missing.
N = Integer(ENV.fetch("N", "1000000"))
class Base
def method_missing(mid, *) = mid
end
class Child < Base
BODY = Ractor.shareable_proc { super() }
define_method(:foo, &BODY)
define_method(:bar, &BODY)
end
[:foo, :bar].map do |mid|
Ractor.new(mid) do |mid|
obj = Child.new
N.times do
got = obj.__send__(mid)
raise "#{mid} returned #{got.inspect}" unless got == mid
end
end
end.each(&:value)
This will eventually result in method_missing being called with the wrong name
Another test also crashes on my arm-based M4 macbook pro. Which I think may be a memory ordering issue of the newly allocated callcache:
N = Integer(ENV.fetch("N", "1000000"))
class Base
def foo = :foo
def bar = :bar
end
class Child < Base
BODY = Ractor.shareable_proc { super() }
define_method(:foo, &BODY)
define_method(:bar, &BODY)
end
[:foo, :bar].map do |mid|
Ractor.new(mid) do |mid|
obj = Child.new
N.times do
got = obj.__send__(mid)
raise "#{mid} returned #{got.inspect}" unless got == mid
end
end
end.each(&:value)
Updated by
Actions