Bug #26

[DOC] Typo in enumerator.c (Enumerator.new)

Added by Arnaud MEURET almost 7 years ago. Updated almost 4 years ago.

[ruby-core:17061]
Status:Closed
Priority:Low
Assignee:Akinori MUSHA
ruby -v: Backport:

Description

=begin
The doc for Enumerable::Enumerator.new(obj, method = :each, *args) states:

Use of this method is not discouraged.

It should probably be:

Use of this method is discouraged.

line 240 in rev #16614
=end

Associated revisions

Revision 8483
Added by Sean Russell almost 10 years ago

Merged in development from the main REXML repository.

  • Fixed bug #34, typo in xpath_parser.
  • Previous fix, (include? -> includes?) was incorrect.
  • Added another test for encoding
  • Started AnyName support in RelaxNG
  • Added Element#Attributes#to_a, so that it does something intelligent. This was needed by XPath, for '@*'
  • Fixed XPath so that @* works.
  • Added xmlgrep to the bin/ directory. A little tool allowing you to grep for XPaths in an XML document.
  • Fixed a CDATA pretty-printing bug. (#39)
  • Fixed a buffering bug in Source.rb that affected the SAX parser This bug was related to how REXML determines the encoding of a file, and evinced itself by hanging on input when using the SAX parser.
  • The unit test for the previous patch. Forgot to commit it.
  • Minor pretty printing fix.
  • Applied Curt Sampson's optimization improvements
  • Issue #9; 3.1.3: The SAX parser was not denormalizing entity references in incoming text. All declared internal entities, as well as numeric entities, should now be denormalized. There was a related bug in that the SAX parser was actually double-encoding entities; this is also fixed.
  • bin/* programs should now be executable. Setting bin apps to executable
  • Issue 14; 3.1.3: DTD events are now all being passed by StreamParser Some of the DTD events were not being passed through by the stream parser.
  • #26: Element#add_element(nil) now raises an error Changed XPath searches so that if a non-Hash is passed, an error is raised Fixed a spurrious undefined method error in encoding. #29: XPath ordering bug fixed by Mark Williams. Incidentally, Mark supplied a superlative bug report, including a full unit test. Then he went ahead and fixed the bug. It doesn't get any better than this, folks.
  • Fixed a broken link. Thanks to Dick Davies for pointing it out. Added functions courtesy of Michael Neumann mneumann@xxxx.de. Example code to follow.
  • Added Michael's sample code. Merged the changes in from branches/xpath_V
  • Fixed preceding:: and following:: axis Fixed the ordering bug that Martin Fowler reported.
  • Uncommented some code commented for testing Applied Nobu's changes to the Encoding infrastructure, which should fix potential threading issues.
  • Added more tests, and the missing syncenumerator class. Fixed the inheritance bug in the pull parser that James Britt found. Indentation changes, and changed some exceptions to runtime exceptions.
  • Changes by Matz, mostly of indent -> indent_level, to avoid function/variable naming conflicts
  • Tabs -> spaces (whitespace)

Note the addition of syncenumerator.rb. This is a stopgap, until I can work on
the class enough to get it accepted as a replacement for the SyncEnumerator
that comes with the Generator class. My version is orders of magnitude faster
than the Generator SyncEnumerator, but is currently missing a couple of
features of the original. Eventually, I expect this class to migrate to
another part of the source tree.

Revision 8483
Added by Sean Russell almost 10 years ago

Merged in development from the main REXML repository.

  • Fixed bug #34, typo in xpath_parser.
  • Previous fix, (include? -> includes?) was incorrect.
  • Added another test for encoding
  • Started AnyName support in RelaxNG
  • Added Element#Attributes#to_a, so that it does something intelligent. This was needed by XPath, for '@*'
  • Fixed XPath so that @* works.
  • Added xmlgrep to the bin/ directory. A little tool allowing you to grep for XPaths in an XML document.
  • Fixed a CDATA pretty-printing bug. (#39)
  • Fixed a buffering bug in Source.rb that affected the SAX parser This bug was related to how REXML determines the encoding of a file, and evinced itself by hanging on input when using the SAX parser.
  • The unit test for the previous patch. Forgot to commit it.
  • Minor pretty printing fix.
  • Applied Curt Sampson's optimization improvements
  • Issue #9; 3.1.3: The SAX parser was not denormalizing entity references in incoming text. All declared internal entities, as well as numeric entities, should now be denormalized. There was a related bug in that the SAX parser was actually double-encoding entities; this is also fixed.
  • bin/* programs should now be executable. Setting bin apps to executable
  • Issue 14; 3.1.3: DTD events are now all being passed by StreamParser Some of the DTD events were not being passed through by the stream parser.
  • #26: Element#add_element(nil) now raises an error Changed XPath searches so that if a non-Hash is passed, an error is raised Fixed a spurrious undefined method error in encoding. #29: XPath ordering bug fixed by Mark Williams. Incidentally, Mark supplied a superlative bug report, including a full unit test. Then he went ahead and fixed the bug. It doesn't get any better than this, folks.
  • Fixed a broken link. Thanks to Dick Davies for pointing it out. Added functions courtesy of Michael Neumann mneumann@xxxx.de. Example code to follow.
  • Added Michael's sample code. Merged the changes in from branches/xpath_V
  • Fixed preceding:: and following:: axis Fixed the ordering bug that Martin Fowler reported.
  • Uncommented some code commented for testing Applied Nobu's changes to the Encoding infrastructure, which should fix potential threading issues.
  • Added more tests, and the missing syncenumerator class. Fixed the inheritance bug in the pull parser that James Britt found. Indentation changes, and changed some exceptions to runtime exceptions.
  • Changes by Matz, mostly of indent -> indent_level, to avoid function/variable naming conflicts
  • Tabs -> spaces (whitespace)

Note the addition of syncenumerator.rb. This is a stopgap, until I can work on
the class enough to get it accepted as a replacement for the SyncEnumerator
that comes with the Generator class. My version is orders of magnitude faster
than the Generator SyncEnumerator, but is currently missing a couple of
features of the original. Eventually, I expect this class to migrate to
another part of the source tree.

Revision 10092
Added by Sean Russell almost 9 years ago

Short summary:

This is a version bump to REXML 3.1.4 for Ruby HEAD. This change log is
identical to the log for the 1.8 branch.

It includes numerous bug fixes and is a pretty big patch, but is nonetheless
a minor revision bump, since the API hasn't changed.

For more information, see:

http:/www.germane-software.com/projects/rexml/milestone/3.1.4

For all tickets, see:

http://www.germane-software.com/projects/rexml/ticket/#

Where '#' is replaced with the ticket number.

Changelog:

  • Fixed the documentation WRT the raw mode of text nodes (ticket #4)
  • Fixes roundup ticket #43: substring-after bug.
  • Fixed ticket #44, Element#xpath
  • Patch submitted by an anonymous doner to allow parsing of Tempfiles. I was hoping that, by now, that whole Source thing would have been changed to use duck typing and avoid this sort of ticket... but in the meantime, the patch has been applied.
  • Fixes ticket:30, XPath default namespace bug. The fix was provided by Lucas Nussbaum.
  • Aliases #size to #length, as per zdennis's request.
  • Fixes typo from previous commit
  • Fixes ticket #32, preceding-sibling fails attempting delete_if on nil nodeset
  • Merges a user-contributed patch for ticket #40
  • Adds a forgotten-to-commit unit test for ticket #32
  • Changes Date, Version, and Copyright to upper case, to avoid conflicts with the Date class. All of the other changes in the altered files are because Subversion doesn't allow block-level commits, like it should. English cased Version and Copyright are aliased to the upper case versions, for partial backward compatability.
  • Resolves ticket #34, SAX parser change makes it impossible to parse IO feeds.
  • Moves parser.source.position() to parser.position()
  • Fixes ticket:48, repeated writes munging text content
  • Fixes ticket:46, adding methods for accessing notation DTD information.
  • Encodes some characters and removes a brokes link in the documentation
  • Deals with carriage returns after XML declarations
  • Improved doctype handling
  • Whitespace handling changes
  • Applies a patch by David Tardon, which (incidentally) fixes ticket:50
  • Closes #26, allowing anything that walks like an IO to be a source.
  • Ticket #31 - One unescape too many This wasn't really a bug, per se... "value" always returns a normalized string, and "value" is the method used to get the text() of an element. However, entities have no meaning in CDATA sections, so there's no justification for value to be normalizing the content of CData objects. This behavior has therefore been changed.
  • Ticket #45 -- Now parses notation declarations in DTDs properly.
  • Resolves ticket #49, Document.parse_stream returns ArgumentError
  • Adds documentation to clarify how XMLDecl works, to avoid invalid bug reports.
  • Addresses ticket #10, fixing the StreamParser API for DTDs.
  • Fixes ticket #42, XPath node-set function 'name' fails with relative node set parameter
  • Good patch by Aaron to fix ticket #53: REXML ignoring unbalanced tags at the end of a document.

Revision 10092
Added by Sean Russell almost 9 years ago

Short summary:

This is a version bump to REXML 3.1.4 for Ruby HEAD. This change log is
identical to the log for the 1.8 branch.

It includes numerous bug fixes and is a pretty big patch, but is nonetheless
a minor revision bump, since the API hasn't changed.

For more information, see:

http:/www.germane-software.com/projects/rexml/milestone/3.1.4

For all tickets, see:

http://www.germane-software.com/projects/rexml/ticket/#

Where '#' is replaced with the ticket number.

Changelog:

  • Fixed the documentation WRT the raw mode of text nodes (ticket #4)
  • Fixes roundup ticket #43: substring-after bug.
  • Fixed ticket #44, Element#xpath
  • Patch submitted by an anonymous doner to allow parsing of Tempfiles. I was hoping that, by now, that whole Source thing would have been changed to use duck typing and avoid this sort of ticket... but in the meantime, the patch has been applied.
  • Fixes ticket:30, XPath default namespace bug. The fix was provided by Lucas Nussbaum.
  • Aliases #size to #length, as per zdennis's request.
  • Fixes typo from previous commit
  • Fixes ticket #32, preceding-sibling fails attempting delete_if on nil nodeset
  • Merges a user-contributed patch for ticket #40
  • Adds a forgotten-to-commit unit test for ticket #32
  • Changes Date, Version, and Copyright to upper case, to avoid conflicts with the Date class. All of the other changes in the altered files are because Subversion doesn't allow block-level commits, like it should. English cased Version and Copyright are aliased to the upper case versions, for partial backward compatability.
  • Resolves ticket #34, SAX parser change makes it impossible to parse IO feeds.
  • Moves parser.source.position() to parser.position()
  • Fixes ticket:48, repeated writes munging text content
  • Fixes ticket:46, adding methods for accessing notation DTD information.
  • Encodes some characters and removes a brokes link in the documentation
  • Deals with carriage returns after XML declarations
  • Improved doctype handling
  • Whitespace handling changes
  • Applies a patch by David Tardon, which (incidentally) fixes ticket:50
  • Closes #26, allowing anything that walks like an IO to be a source.
  • Ticket #31 - One unescape too many This wasn't really a bug, per se... "value" always returns a normalized string, and "value" is the method used to get the text() of an element. However, entities have no meaning in CDATA sections, so there's no justification for value to be normalizing the content of CData objects. This behavior has therefore been changed.
  • Ticket #45 -- Now parses notation declarations in DTDs properly.
  • Resolves ticket #49, Document.parse_stream returns ArgumentError
  • Adds documentation to clarify how XMLDecl works, to avoid invalid bug reports.
  • Addresses ticket #10, fixing the StreamParser API for DTDs.
  • Fixes ticket #42, XPath node-set function 'name' fails with relative node set parameter
  • Good patch by Aaron to fix ticket #53: REXML ignoring unbalanced tags at the end of a document.

History

#1 Updated by Yukihiro Matsumoto almost 7 years ago

  • Due date set to 06/03/2008
  • Status changed from Open to Closed
  • Assignee set to Akinori MUSHA

=begin

=end

#2 Updated by Akinori MUSHA almost 7 years ago

  • % Done changed from 0 to 100

=begin
Committed to trunk and ruby_1_8, thanks!
=end

Also available in: Atom PDF