Project

General

Profile

Bug #3400

apparent typos in ext/openssl/openssl_missing.{h,c}

Added by aquark (Adrian Quark) almost 8 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
nahi (Hiroshi Nakamura)
Target version:
1.9.3
ruby -v:
n/a
Backport:
2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN
[ruby-core:30626]

Description

=begin
There are some apparent typos in the "if defined" checks in openssl_missing.{h,c} which could potentially cause compatibility problems with future versions of OpenSSL. See the attached patch. The patch was generated against the trunk r27864.
=end

ruby-openssl.patch (1.45 KB) ruby-openssl.patch aquark (Adrian Quark), 06/07/2010 04:06 AM

Associated revisions

Revision dad43c29
Added by nahi (Hiroshi Nakamura) over 7 years ago

  • Fixed wrong check of missing functions. Patch by Adrian Quark. ref #3400 The patch contains following comment: This patch should avoid unnecessary incompatibility with future versions of Openssl. Changes suggested by bmaher_at_amazon.com.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@29190 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 29190
Added by nahi (Hiroshi Nakamura) over 7 years ago

  • Fixed wrong check of missing functions. Patch by Adrian Quark. ref #3400 The patch contains following comment: This patch should avoid unnecessary incompatibility with future versions of Openssl. Changes suggested by bmaher_at_amazon.com.

Revision 29190
Added by nahi (Hiroshi Nakamura) over 7 years ago

  • Fixed wrong check of missing functions. Patch by Adrian Quark. ref #3400 The patch contains following comment: This patch should avoid unnecessary incompatibility with future versions of Openssl. Changes suggested by bmaher_at_amazon.com.

Revision 29190
Added by nahi (Hiroshi Nakamura) over 7 years ago

  • Fixed wrong check of missing functions. Patch by Adrian Quark. ref #3400 The patch contains following comment: This patch should avoid unnecessary incompatibility with future versions of Openssl. Changes suggested by bmaher_at_amazon.com.

Revision 29190
Added by nahi (Hiroshi Nakamura) over 7 years ago

  • Fixed wrong check of missing functions. Patch by Adrian Quark. ref #3400 The patch contains following comment: This patch should avoid unnecessary incompatibility with future versions of Openssl. Changes suggested by bmaher_at_amazon.com.

Revision 29190
Added by nahi (Hiroshi Nakamura) over 7 years ago

  • Fixed wrong check of missing functions. Patch by Adrian Quark. ref #3400 The patch contains following comment: This patch should avoid unnecessary incompatibility with future versions of Openssl. Changes suggested by bmaher_at_amazon.com.

Revision ffb91379
Added by yugui (Yuki Sonoda) over 7 years ago

merges r29190 from trunk into ruby_1_9_2.

    * Fixed wrong check of missing functions. Patch by Adrian Quark.
      ref #3400
      The patch contains following comment:
        This patch should avoid unnecessary incompatibility with future
        versions of Openssl.  Changes suggested by bmaher_at_amazon.com.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_2@29662 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

History

#1 Updated by nahi (Hiroshi Nakamura) almost 8 years ago

=begin
To administrator: allow me to update this ticket, please?
=end

#2 Updated by naruse (Yui NARUSE) almost 8 years ago

=begin
Added
=end

#3 Updated by nahi (Hiroshi Nakamura) almost 8 years ago

  • Assignee set to nahi (Hiroshi Nakamura)

=begin
Yui: Thanks!
=end

#4 Updated by nahi (Hiroshi Nakamura) over 7 years ago

  • Status changed from Open to Closed
  • Target version set to 1.9.3

=begin
Adrian, I checked the patch and confirmed that all of the fix are for typo. Applied it. Thank you!
=end

Also available in: Atom PDF