Project

General

Profile

Actions

Bug #3452

closed

ENV 'make' is not considered in the rubygems test.

Added by tarui (Masaya Tarui) about 12 years ago. Updated over 11 years ago.

Status:
Closed
Priority:
Normal
Target version:
ruby -v:
ruby 1.9.2dev
Backport:
[ruby-core:30820]

Description

=begin
Hi, Eric

the test fails follows.

$make=which make ruby test/rubygems/test_gem_ext_configure_builder.rb

  1. Failure:
    test_self_build(TestGemExtConfigureBuilder) [test/rubygems/test_gem_ext_configure_builder.rb:33]:
    Expected "make", not "/usr/bin/make".
  2. Failure:
    test_self_build_has_makefile(TestGemExtConfigureBuilder) [test/rubygems/test_gem_ext_configure_builder.rb:79]:
    Expected "make", not "/usr/bin/make".

on Windows,

nmake install test-all
also fails.
because defined MAKE by 'install' target, and environment's variable name is not case-sensitive on Windows.

I have some questions.

  1. Is it intentional to use not ENV['MAKE'] but ENV['make'] at rubygems/ext/builder.rb ?

  2. What do you want to test by test_self_build, test_self_build_has_makefile, test_class_build and test_clas_make?
    Is it necessary to check make command?
    If you think that, you should do unsetenv or check ENV.

I think that the redefine of MAKE at 'make install' is wrong, but it is another problem.
=end


Related issues 1 (0 open1 closed)

Has duplicate Ruby master - Bug #3430: ENV 'MAKE' is not considered in the gem test.Closed06/12/2010Actions
Actions

Also available in: Atom PDF