Bug #3983

nmake install fail on Windows with r29591

Added by Heesob Park over 4 years ago. Updated almost 4 years ago.

[ruby-core:32901]
Status:Closed
Priority:Normal
Assignee:-
ruby -v:ruby 1.9.3dev (2010-10-26 trunk 29591) [i386-mswin32_90] Backport:

Description

=begin
Due to the Revision r29591, nmake install fails on Windows with MSVC.

C:\work\snapshot>nmake install

...

installing binary commands: /usr/bin
installing base libraries: /usr/lib
installing arch files: /usr/lib/ruby/1.9.1/i386-mswin32_90
./tool/rbinstall.rb:343:in exist?': can't convert nil into String (TypeError)
from ./tool/rbinstall.rb:343:in
block in '
from ./tool/rbinstall.rb:555:in call'
from ./tool/rbinstall.rb:555:in
block (2 levels) in '
from ./tool/rbinstall.rb:552:in each'
from ./tool/rbinstall.rb:552:in
block in '
from ./tool/rbinstall.rb:548:in each'
from ./tool/rbinstall.rb:548:in
'
NMAKE : fatal error U1077: '.\miniruby.exe' : return code '0x1'
Stop.

Here is a patch

--- rbinstall.rb 2010-10-26 10:13:58.000000000 +0900
+++ rbinstall.rb.new 2010-10-26 10:15:34.000000000 +0900
@@ -340,7 +340,7 @@

install?(:local, :arch, :data) do
pc = CONFIG["ruby_pc"]
- if File.exist?(pc)
+ if pc && File.exist?(pc)
prepare "pkgconfig data", pkgconfigdir = File.join(libdir, "pkgconfig")
install pc, pkgconfigdir, :mode => $data_mode
end
=end

Associated revisions

Revision 29595
Added by Nobuyoshi Nakada over 4 years ago

  • common.mk (pkgconfig-data): moved from Makefile.in.

  • tool/rbinstall.rb: install pc file only if non-empty.
    #3983

  • win32/Makefile.sub (ruby_pc): create pc file.

Revision 29595
Added by Nobuyoshi Nakada over 4 years ago

  • common.mk (pkgconfig-data): moved from Makefile.in.

  • tool/rbinstall.rb: install pc file only if non-empty.
    #3983

  • win32/Makefile.sub (ruby_pc): create pc file.

History

#1 Updated by Nobuyoshi Nakada over 4 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

=begin
This issue was solved with changeset r29595.
Heesob, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

=end

Also available in: Atom PDF