Bug #4067

[PATCH] Fix SystemStackError when trying to format a large block of text in REXML

Added by Jeremy Evans about 5 years ago. Updated over 4 years ago.

Assignee:Kouhei Sutou
ruby -v:ruby 1.9.2p0 (2010-08-18 revision 29036) [x86_64-openbsd4.8] Backport:


REXML::Formatters::Pretty#wrap used a recursive method call to format text. This patch switches it to use an iterative approach. It includes a test case exposing the error.

This issue isn't theoretical, it happens when using rcov with Sequel's test suite.

Tested on 1.9.2p0, but patch is against trunk.

rexml_fix.diff Magnifier - Patch for REXML::Formatters::Pretty#wrap (1.83 KB) Jeremy Evans, 11/18/2010 07:46 AM


#1 Updated by Kouhei Sutou about 5 years ago

  • Assignee set to Kouhei Sutou
  • Target version set to 2.0.0



#2 Updated by Kouhei Sutou about 5 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r29827.
Jeremy, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


Also available in: Atom PDF