Bug #4511

Ripper#end_seen? の戻り値に関するコメント

Added by Sho Hashimoto almost 4 years ago. Updated over 3 years ago.

[ruby-dev:<unknown>]
Status:Closed
Priority:Low
Assignee:Yui NARUSE
ruby -v:ruby 1.9.3dev (2011-03-19 trunk 31128) [x86_64-linux] Backport:

Description

=begin
Ripper#end_seen? は true か false しか返さないと思うので、コメントが間違っている気がします。例えば、以下のような修正になるのではないではないかと思います。

  • * Return if parsed source ended by +__END__+.
  • * This number starts from 1.
  • * Return true if parsed source ended by +__END__+.

パッチも添付しておきますので、問題ないようでしたら、取り込んでやってください。
=end

parse.y.patch Magnifier (411 Bytes) Sho Hashimoto, 03/19/2011 02:03 PM

Associated revisions

Revision 32239
Added by Yui NARUSE over 3 years ago

  • parse.y (rb_parser_end_seen_p): fix documentation about return value. patched by Sho Hashimoto. [Bug #4511]

Revision 32239
Added by Yui NARUSE over 3 years ago

  • parse.y (rb_parser_end_seen_p): fix documentation about return value. patched by Sho Hashimoto. [Bug #4511]

History

#1 Updated by Yui NARUSE over 3 years ago

  • Status changed from Open to Assigned
  • Assignee set to Yui NARUSE

#2 Updated by Yui NARUSE over 3 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r32239.
Sho, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • parse.y (rb_parser_end_seen_p): fix documentation about return value. patched by Sho Hashimoto. [Bug #4511]

Also available in: Atom PDF