Feature #4528

[PATCH] ext/io/nonblock: avoid unnecessary fcntl F_SETFL calls

Added by Eric Wong over 4 years ago. Updated about 4 years ago.

Assignee:Motohiro KOSAKI


Avoid F_SETFL if we're not changing the O_NONBLOCK bit. F_SETFL
is an expensive operation since it needs to affect all processes
with the same file object.

rb_io_set_nonblock() implements similar logic to avoid F_SETFL
in io.c

0001-ext-io-nonblock-avoid-unnecessary-fcntl-F_SETFL-call.patch Magnifier (1.07 KB) Eric Wong, 03/26/2011 03:38 AM


#1 Updated by Motohiro KOSAKI over 4 years ago

  • Status changed from Open to Assigned
  • Assignee set to Motohiro KOSAKI

Looks good to me. I'll commit this if nobody put objections.


#2 Updated by Motohiro KOSAKI about 4 years ago

  • Status changed from Assigned to Closed
  • Target version changed from 2.0.0 to 1.9.3



Also available in: Atom PDF