Feature #4528

[PATCH] ext/io/nonblock: avoid unnecessary fcntl F_SETFL calls

Added by Eric Wong about 3 years ago. Updated almost 3 years ago.

[ruby-core:35556]
Status:Closed
Priority:Low
Assignee:Motohiro KOSAKI
Category:ext
Target version:1.9.3

Description

=begin
Avoid FSETFL if we're not changing the ONONBLOCK bit. F_SETFL
is an expensive operation since it needs to affect all processes
with the same file object.

rbiosetnonblock() implements similar logic to avoid FSETFL
in io.c
=end

0001-ext-io-nonblock-avoid-unnecessary-fcntl-F_SETFL-call.patch Magnifier (1.07 KB) Eric Wong, 03/26/2011 03:38 AM

History

#1 Updated by Motohiro KOSAKI about 3 years ago

  • Status changed from Open to Assigned
  • Assignee set to Motohiro KOSAKI

=begin
Looks good to me. I'll commit this if nobody put objections.

=end

#2 Updated by Motohiro KOSAKI about 3 years ago

  • Status changed from Assigned to Closed
  • Target version changed from 2.0.0 to 1.9.3

=begin
r31238.

=end

Also available in: Atom PDF