Project

General

Profile

Backport #6063

OpenStruct#delete_field missing return value

Added by oruen (Nick Recobra) over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
[ruby-core:42807]

Description

From a description of the OpenStruct#delete_field method it should return the value of the deleted field. I've found it to be broken on current trunk. Patch attached contains a fix for the issue and a test for it.


Files

openstruct-delete-field-fix.patch (953 Bytes) openstruct-delete-field-fix.patch oruen (Nick Recobra), 02/23/2012 02:12 AM

Associated revisions

Revision dfb1a712
Added by marcandre (Marc-Andre Lafortune) over 7 years ago

  • lib/ostruct.rb (delete_field): Bug fix so previous value is returned.
    Patch by Nick Recobra [Bug #6063]

  • test/ostruct/test_ostruct.rb: Test for above

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34755 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 34755
Added by marcandre (Marc-Andre Lafortune) over 7 years ago

  • lib/ostruct.rb (delete_field): Bug fix so previous value is returned.
    Patch by Nick Recobra [Bug #6063]

  • test/ostruct/test_ostruct.rb: Test for above

Revision 34755
Added by marcandre (Marc-Andre Lafortune) over 7 years ago

  • lib/ostruct.rb (delete_field): Bug fix so previous value is returned.
    Patch by Nick Recobra [Bug #6063]

  • test/ostruct/test_ostruct.rb: Test for above

Revision 34755
Added by marcandre (Marc-Andre Lafortune) over 7 years ago

  • lib/ostruct.rb (delete_field): Bug fix so previous value is returned.
    Patch by Nick Recobra [Bug #6063]

  • test/ostruct/test_ostruct.rb: Test for above

Revision 34755
Added by marcandre (Marc-Andre Lafortune) over 7 years ago

  • lib/ostruct.rb (delete_field): Bug fix so previous value is returned.
    Patch by Nick Recobra [Bug #6063]

  • test/ostruct/test_ostruct.rb: Test for above

Revision 34755
Added by marcandre (Marc-Andre Lafortune) over 7 years ago

  • lib/ostruct.rb (delete_field): Bug fix so previous value is returned.
    Patch by Nick Recobra [Bug #6063]

  • test/ostruct/test_ostruct.rb: Test for above

Revision 34755
Added by marcandre (Marc-Andre Lafortune) over 7 years ago

  • lib/ostruct.rb (delete_field): Bug fix so previous value is returned.
    Patch by Nick Recobra [Bug #6063]

  • test/ostruct/test_ostruct.rb: Test for above

Revision 76dc4b9a
Added by naruse (Yui NARUSE) over 7 years ago

merge revision(s) 34755:

    * lib/ostruct.rb (delete_field): Bug fix so previous value is
      returned. Patch by Nick Recobra [Bug #6063]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@34791 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 34791
Added by naruse (Yui NARUSE) over 7 years ago

merge revision(s) 34755:

* lib/ostruct.rb (delete_field): Bug fix so previous value is
  returned. Patch by Nick Recobra [Bug #6063]

History

#1

Updated by marcandre (Marc-Andre Lafortune) over 7 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r34755.
Nick, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • lib/ostruct.rb (delete_field): Bug fix so previous value is returned.
    Patch by Nick Recobra [Bug #6063]

  • test/ostruct/test_ostruct.rb: Test for above

#2

Updated by marcandre (Marc-Andre Lafortune) over 7 years ago

  • Tracker changed from Bug to Backport
  • Project changed from Ruby master to Backport193
  • Category deleted (lib)
  • Status changed from Closed to Open
  • Target version deleted (1.9.3)
#3

Updated by naruse (Yui NARUSE) over 7 years ago

  • Status changed from Open to Closed

This issue was solved with changeset r34791.
Nick, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 34755:

* lib/ostruct.rb (delete_field): Bug fix so previous value is
  returned. Patch by Nick Recobra [Bug #6063]

Also available in: Atom PDF