Bug #6700: [PATCH] Fix some 4xx status classes to inherit correctly from Net::HTTPClientError

• Status: Closed
• Assignee: knu (Akinori MUSHA)
• Target version: 2.0.0
• ruby -v: ruby 2.0.0dev (2012-07-05 trunk 36311) [x86_64-darwin11.4.2]

[madeofcode (Mark Dodwell)]

These recently added 4xx status classes were inheriting from Net::HTTPSuccess, which seems incorrect.

I believe they should inherit from Net::HTTPClientError, as with all the other 4xx cases.

Note that this change subtly alters/fixes the behavior of these classes since they will now inherit the EXCEPTION_TYPE = Net::HTTPServerException from Net::HTTPClientError which they would not have had previously. I expect that's disable, but just wanted to flag that.

[madeofcode (Mark Dodwell)]

s/disable/desirable/

[knu (Akinori MUSHA)]

• Status changed from Open to Assigned
• Assignee set to knu (Akinori MUSHA)

[knu (Akinori MUSHA)]

• Status changed from Assigned to Closed
• % Done changed from 0 to 100

This issue was solved with changeset r36316.
Mark, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

• lib/net/http/responses.rb: Fix 4xx classes to inherit correctly
  from Net::HTTPClientError. [Bug #6700]

[knu (Akinori MUSHA)]

Thanks for pointing it out. I merged your patch and added a test.