Bug #6753

Comparing Date::Infinity with Date/DateTime

Added by herwinw (Herwin Quarantainenet) almost 5 years ago. Updated almost 5 years ago.

Target version:
ruby -v:
ruby 1.9.3p0 (2011-10-30 revision 33570) [i686-linux]


Depending on the order you use for comparing, this works or throws an error. A snippet from IRB

irb(main):001:0> require 'date'
=> true
irb(main):002:0> <
=> true
irb(main):003:0> >
ArgumentError: comparison of Date::Infinity with DateTime failed

The same thing happens when using Date instead of DateTime.

The problem arises in Date::Infinity#<=>(other). This method checks if the other is a Date::Infinity (it is not) or a Numeric (it is not). It then falls back to the generic code, which calls other.coerce. Since both instances of DateTime and Date don't have a coerce method this fails.

I've fixed the problem here by adding this line to Date::Infinity#<=>(other)

when DateTime, Date; return d

This is not optimal, because when you'll try to compare an instance created with, it will always return 0 when comparing with a Date(Time), which means any Date(Time) will be equal to Then again, I don't see the use case where you would initialize the Date::Infinity with a value of 0, and the same problem happens when you're comparing it with a Numeric.

irb(main):006:0> == 4
=> true

I'm not really familiar with the background of the coerce method, but relying on the coerce of a given parameter seems a little bit weird to me. There is no check on the type of the parameter (except it is not Date::Infinity and not numeric) which means the coerce method can be anything (if it exists).


#1 [ruby-core:46559] Updated by tadf (tadayoshi funaba) almost 5 years ago

  • Status changed from Open to Assigned
  • Assignee set to tadf (tadayoshi funaba)
  • Priority changed from Normal to 3

#2 [ruby-core:46560] Updated by tadf (tadayoshi funaba) almost 5 years ago

  • Status changed from Assigned to Rejected

Date::Infinity was designed as a numeric class.

same as:

this undocumented class was provided only for internal use.
and now it is just for backward compatibility.

Also available in: Atom PDF