Uninformative exception in FIPS mode
irb(main):001:0> require 'openssl'
=> -----BEGIN DH PARAMETERS-----
-----END DH PARAMETERS-----
OpenSSL::PKey::DHError: BN lib
from /bin/irb:12:in `'
Could you please provide better exception message? While it is fine that DH.new fails with short key, it is not obvious from the message what is the reason. Thank you.
#2 [ruby-core:47336] Updated by MartinBosslet (Martin Bosslet) over 5 years ago
I'm not sure whether this is possible at all - the message being generated is what OpenSSL itself generates at this point. I'd have to check if there is a reliable way to detect whether we are in FIPS mode or not. Still, I'd prefer if OpenSSL itself provided a better exception message.
#4 [ruby-core:50996] Updated by MartinBosslet (Martin Bosslet) almost 5 years ago
- Status changed from Assigned to Third Party's Issue
This is indeed a third party issue. The exception message (or better, the lack thereof) is generated by OpenSSL. They're fine for RSA, DSA and EC ("key too short"), but miserable for DH, agreed.
I really wouldn't want to start to improve OpenSSL error messages in the Ruby extension, that's not where this belongs IMHO. We could try to open an issue on the OpenSSL tracker, though.
Closing as TPI for now, please feel free to reopen if your opinions differ from mine.