Feature #7067

IO#reopen should accept File::Constants

Added by Masaki Matsushita over 1 year ago. Updated over 1 year ago.

[ruby-core:47694]
Status:Closed
Priority:Normal
Assignee:Masaki Matsushita
Category:core
Target version:2.0.0

Description

Hello,

I think IO#reopen should accept File::Constants because it is difficult to get mode string from File::Constants.
I have attached a patch.

patch.diff Magnifier (1.81 KB) Masaki Matsushita, 09/25/2012 11:58 PM

patch.diff Magnifier (1.64 KB) Masaki Matsushita, 09/27/2012 11:34 PM

Associated revisions

Revision 37041
Added by Nobuyoshi Nakada over 1 year ago

io.c: IO#reopen int mode

  • io.c (rbioreopen): accept File::Constants as well as mode string. based on the patch by Glass_saga (Masaki Matsushita) in . [Feature #7067]

History

#1 Updated by Nobuyoshi Nakada over 1 year ago

  • Assignee set to Masaki Matsushita

Seems fine to me.

#2 Updated by Masaki Matsushita over 1 year ago

Sorry, I made a mistake.
The patch is untabified code.
I have attached tabified one.

#3 Updated by Nobuyoshi Nakada over 1 year ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r37041.
Masaki, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


io.c: IO#reopen int mode

  • io.c (rbioreopen): accept File::Constants as well as mode string. based on the patch by Glass_saga (Masaki Matsushita) in . [Feature #7067]

Also available in: Atom PDF