Backport #7294

Backport #7285: some failures on RubyInstaller CI

Fix CI test_dir_m17n.rb failures

Added by Luis Lavena over 1 year ago. Updated over 1 year ago.

[ruby-core:48992]
Status:Closed
Priority:Normal
Assignee:Usaku NAKAMURA

Description

Hello,

Please backport the commits of Bug #6765 (r36509, r36514) to solve the RubyInstaller CI failures.

Find attached the diff that contains both commits to be applied to ruby19_3 branch.

Thank you.

0001-backport-bug-6765.diff Magnifier (7.7 KB) Luis Lavena, 11/07/2012 04:55 AM

Associated revisions

Revision 37554
Added by Usaku NAKAMURA over 1 year ago

merge revision(s) 36509,36514: [Backport #7294]

* test/ruby/test_dir_m17n.rb (create_and_check_raw_file_name): add new
  helper method to ease encoding testing. Patch by Oleg Sukhodolsky.
  [Bug #6765]

* test/ruby/test_dir_m17n.rb (test_filename_extutf8): use filesystem
  encoding when reading entries and comparing.

* test/ruby/test_dir_m17n.rb (test_filename_utf8_raw_name): removed.

* test/ruby/test_dir_m17n.rb (test_filename_utf8_raw_jp_name): split test.

* test/ruby/test_dir_m17n.rb: refactoring. RE should be in the left side
  of the =~ operator, and compare the result with nil is meaningless.

History

#1 Updated by Usaku NAKAMURA over 1 year ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r37554.
Luis, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 36509,36514: [Backport #7294]

* test/ruby/test_dir_m17n.rb (create_and_check_raw_file_name): add new
  helper method to ease encoding testing. Patch by Oleg Sukhodolsky.
  [Bug #6765]

* test/ruby/test_dir_m17n.rb (test_filename_extutf8): use filesystem
  encoding when reading entries and comparing.

* test/ruby/test_dir_m17n.rb (test_filename_utf8_raw_name): removed.

* test/ruby/test_dir_m17n.rb (test_filename_utf8_raw_jp_name): split test.

* test/ruby/test_dir_m17n.rb: refactoring. RE should be in the left side
  of the =~ operator, and compare the result with nil is meaningless.

Also available in: Atom PDF