Project

General

Profile

Actions

Backport #7294

closed

Backport #7285: some failures on RubyInstaller CI

Fix CI test_dir_m17n.rb failures

Added by luislavena (Luis Lavena) about 12 years ago. Updated about 12 years ago.

Status:
Closed
[ruby-core:48992]

Description

Hello,

Please backport the commits of Bug #6765 (r36509, r36514) to solve the RubyInstaller CI failures.

Find attached the diff that contains both commits to be applied to ruby_1_9_3 branch.

Thank you.


Files

0001-backport-bug-6765.diff (7.7 KB) 0001-backport-bug-6765.diff luislavena (Luis Lavena), 11/07/2012 04:55 AM
Actions #1

Updated by usa (Usaku NAKAMURA) about 12 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r37554.
Luis, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 36509,36514: [Backport #7294]

* test/ruby/test_dir_m17n.rb (create_and_check_raw_file_name): add new
  helper method to ease encoding testing. Patch by Oleg Sukhodolsky.
  [ruby-core:46589][Bug #6765]

* test/ruby/test_dir_m17n.rb (test_filename_extutf8): use filesystem
  encoding when reading entries and comparing.

* test/ruby/test_dir_m17n.rb (test_filename_utf8_raw_name): removed.

* test/ruby/test_dir_m17n.rb (test_filename_utf8_raw_jp_name): split test.

* test/ruby/test_dir_m17n.rb: refactoring. RE should be in the left side
  of the =~ operator, and compare the result with nil is meaningless.
Actions

Also available in: Atom PDF

Like0
Like0