Project

General

Profile

Bug #7495

Clean up a few calls to rb_intern()

Added by Charlie Somerville over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
ruby -v:
ruby 2.0.0dev (2012-12-02 trunk 38137) [x86_64-darwin11.4.0]
[ruby-core:50472]

Description

This isn't really a bug, but it's not really a feature either so I wasn't sure what tracker to file this under. Apologies if I chose the wrong one.

This patch just cleans up a few calls to rb_intern() and replaces them with references to values from id.h

clean_up_rb_interns.patch View (6.07 KB) Charlie Somerville, 12/02/2012 03:00 PM

Associated revisions

Revision 38143
Added by Koichi Sasada over 3 years ago

  • array.c, enum.c, insns.def, io.c, numeric.c, parse.y, process.c, range.c: use prepared IDs. A patch from charliesome (Charlie Somerville). [Bug #7495]
  • common.mk: add dependency to id.h.
  • common.mk: replace ID_H_INCLUDES with id.h.

Revision 38143
Added by Koichi Sasada over 3 years ago

  • array.c, enum.c, insns.def, io.c, numeric.c, parse.y, process.c, range.c: use prepared IDs. A patch from charliesome (Charlie Somerville). [Bug #7495]
  • common.mk: add dependency to id.h.
  • common.mk: replace ID_H_INCLUDES with id.h.

Revision 38143
Added by Koichi Sasada over 3 years ago

  • array.c, enum.c, insns.def, io.c, numeric.c, parse.y, process.c, range.c: use prepared IDs. A patch from charliesome (Charlie Somerville). [Bug #7495]
  • common.mk: add dependency to id.h.
  • common.mk: replace ID_H_INCLUDES with id.h.

History

#1 Updated by Koichi Sasada over 3 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r38143.
Charlie, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • array.c, enum.c, insns.def, io.c, numeric.c, parse.y, process.c, range.c: use prepared IDs. A patch from charliesome (Charlie Somerville). [Bug #7495]
  • common.mk: add dependency to id.h.
  • common.mk: replace ID_H_INCLUDES with id.h.

#2 [ruby-core:50484] Updated by Koichi Sasada over 3 years ago

I applied your patch. Thanks!

Also available in: Atom PDF