Backport #8070

Backport r39697

Added by Luis Lavena about 1 year ago. Updated about 1 year ago.

[ruby-core:53284]
Status:Closed
Priority:Normal
Assignee:Usaku NAKAMURA

Description

Hello,

Please backport r39697 as it fixes a bug reported in #8034

Thank you

backport-8034-ruby_1_9_3.diff Magnifier (7.02 KB) Luis Lavena, 03/14/2013 02:03 PM


Related issues

Related to ruby-trunk - Bug #8034: File.expand_path('something', '~') do not include home path Closed 03/06/2013

Associated revisions

Revision 39982
Added by Usaku NAKAMURA about 1 year ago

merge revision(s) 39697,39701,39716,39740,39751: [Backport #8070]

* win32/file.c (rb_file_expand_path_internal):  Expand home directory when
  used as second parameter (dir_string).   [Bug #8034]

* test/ruby/test_file_exhaustive.rb: add test to verify.

* win32/file.c (get_user_from_path):  add internal function that retrieves
  username from supplied path (refactored).

* win32/file.c (rb_file_expand_path_internal):  refactor expansion of user
  home to use get_user_from_path and cover dir_string corner cases.
   [Bug #8034]

History

#1 Updated by Luis Lavena about 1 year ago

Hello,

As pointed out by nobu, the original revision might not be enough.

The final list of revisions required are:

r39697
r39701
r39716
r39740
r39751

To simply the process I have attached a patch with the revisions combined.

Thank you.

#2 Updated by Usaku NAKAMURA about 1 year ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r39982.
Luis, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 39697,39701,39716,39740,39751: [Backport #8070]

* win32/file.c (rb_file_expand_path_internal):  Expand home directory when
  used as second parameter (dir_string).   [Bug #8034]

* test/ruby/test_file_exhaustive.rb: add test to verify.

* win32/file.c (get_user_from_path):  add internal function that retrieves
  username from supplied path (refactored).

* win32/file.c (rb_file_expand_path_internal):  refactor expansion of user
  home to use get_user_from_path and cover dir_string corner cases.
   [Bug #8034]

Also available in: Atom PDF