Backport #8132

backport r39834 and r39837

Added by Tomoyuki Chikanaga about 1 year ago. Updated about 1 year ago.

[ruby-core:53572]
Status:Closed
Priority:Normal
Assignee:Usaku NAKAMURA

Description

r39834 and r39837 seems fix a error on vc10-x64 rubyci.

Associated revisions

Revision 39859
Added by Usaku NAKAMURA about 1 year ago

merge revision(s) 39809,39834,39837: [Backport #8132]

* test/win32ole/test_err_in_callback.rb
  (TestErrInCallBack#test_err_in_callback): shouldn't create a file in
  source directory.

* test/win32ole/test_err_in_callback.rb (TestErrInCallBack#setup): use
  relative path to get rid of "too long commandline" error.
  the top of build directory.

* test/win32ole/test_err_in_callback.rb (TestErrInCallBack#setup):
  allow using different root for source and build directories.
  this may fixes a minor problem of r39834.

History

#1 Updated by Tomoyuki Chikanaga about 1 year ago

... and I need to backport r39809 too.

#2 Updated by Tomoyuki Chikanaga about 1 year ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r39851.
Tomoyuki, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 39809,39834,39837: [Backport #8132]

* test/win32ole/test_err_in_callback.rb
  (TestErrInCallBack#test_err_in_callback): shouldn't create a file in
  source directory.

* test/win32ole/test_err_in_callback.rb (TestErrInCallBack#setup): use
  relative path to get rid of "too long commandline" error.
  the top of build directory.

* test/win32ole/test_err_in_callback.rb (TestErrInCallBack#setup):
  allow using different root for source and build directories.
  this may fixes a minor problem of r39834.

#3 Updated by Usaku NAKAMURA about 1 year ago

  • Project changed from Backport200 to Backport93
  • Status changed from Closed to Assigned
  • Assignee changed from Tomoyuki Chikanaga to Usaku NAKAMURA

#4 Updated by Usaku NAKAMURA about 1 year ago

  • Status changed from Assigned to Closed

This issue was solved with changeset r39859.
Tomoyuki, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 39809,39834,39837: [Backport #8132]

* test/win32ole/test_err_in_callback.rb
  (TestErrInCallBack#test_err_in_callback): shouldn't create a file in
  source directory.

* test/win32ole/test_err_in_callback.rb (TestErrInCallBack#setup): use
  relative path to get rid of "too long commandline" error.
  the top of build directory.

* test/win32ole/test_err_in_callback.rb (TestErrInCallBack#setup):
  allow using different root for source and build directories.
  this may fixes a minor problem of r39834.

Also available in: Atom PDF