Project

General

Profile

Backport #8132

backport r39834 and r39837

Added by nagachika (Tomoyuki Chikanaga) over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
[ruby-core:53572]

Description

r39834 and r39837 seems fix a error on vc10-x64 rubyci.

Associated revisions

Revision 2aaa9ab9
Added by nagachika (Tomoyuki Chikanaga) over 6 years ago

merge revision(s) 39809,39834,39837: [Backport #8132]

    * test/win32ole/test_err_in_callback.rb
      (TestErrInCallBack#test_err_in_callback): shouldn't create a file in
      source directory.

    * test/win32ole/test_err_in_callback.rb (TestErrInCallBack#setup): use
      relative path to get rid of "too long commandline" error.
      the top of build directory.

    * test/win32ole/test_err_in_callback.rb (TestErrInCallBack#setup):
      allow using different root for source and build directories.
      this may fixes a minor problem of r39834.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@39851 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 1191b359
Added by usa (Usaku NAKAMURA) over 6 years ago

merge revision(s) 39809,39834,39837: [Backport #8132]

    * test/win32ole/test_err_in_callback.rb
      (TestErrInCallBack#test_err_in_callback): shouldn't create a file in
      source directory.

    * test/win32ole/test_err_in_callback.rb (TestErrInCallBack#setup): use
      relative path to get rid of "too long commandline" error.
      the top of build directory.

    * test/win32ole/test_err_in_callback.rb (TestErrInCallBack#setup):
      allow using different root for source and build directories.
      this may fixes a minor problem of r39834.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@39859 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 39859
Added by usa (Usaku NAKAMURA) over 6 years ago

merge revision(s) 39809,39834,39837: [Backport #8132]

* test/win32ole/test_err_in_callback.rb
  (TestErrInCallBack#test_err_in_callback): shouldn't create a file in
  source directory.

* test/win32ole/test_err_in_callback.rb (TestErrInCallBack#setup): use
  relative path to get rid of "too long commandline" error.
  the top of build directory.

* test/win32ole/test_err_in_callback.rb (TestErrInCallBack#setup):
  allow using different root for source and build directories.
  this may fixes a minor problem of r39834.

History

Updated by nagachika (Tomoyuki Chikanaga) over 6 years ago

... and I need to backport r39809 too.

#2

Updated by nagachika (Tomoyuki Chikanaga) over 6 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r39851.
Tomoyuki, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 39809,39834,39837: [Backport #8132]

* test/win32ole/test_err_in_callback.rb
  (TestErrInCallBack#test_err_in_callback): shouldn't create a file in
  source directory.

* test/win32ole/test_err_in_callback.rb (TestErrInCallBack#setup): use
  relative path to get rid of "too long commandline" error.
  the top of build directory.

* test/win32ole/test_err_in_callback.rb (TestErrInCallBack#setup):
  allow using different root for source and build directories.
  this may fixes a minor problem of r39834.
#3

Updated by usa (Usaku NAKAMURA) over 6 years ago

  • Project changed from Backport200 to Backport193
  • Status changed from Closed to Assigned
  • Assignee changed from nagachika (Tomoyuki Chikanaga) to usa (Usaku NAKAMURA)
#4

Updated by usa (Usaku NAKAMURA) over 6 years ago

  • Status changed from Assigned to Closed

This issue was solved with changeset r39859.
Tomoyuki, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 39809,39834,39837: [Backport #8132]

* test/win32ole/test_err_in_callback.rb
  (TestErrInCallBack#test_err_in_callback): shouldn't create a file in
  source directory.

* test/win32ole/test_err_in_callback.rb (TestErrInCallBack#setup): use
  relative path to get rid of "too long commandline" error.
  the top of build directory.

* test/win32ole/test_err_in_callback.rb (TestErrInCallBack#setup):
  allow using different root for source and build directories.
  this may fixes a minor problem of r39834.

Also available in: Atom PDF