Project

General

Profile

Backport #8587

Back porting r41623

Added by mrkn (Kenta Murata) over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
[ruby-dev:47472]

Description

r41623 fixes a bug of BigMath.exp in the case of negative non-BigDecimal arguments.

cf. https://github.com/ruby/ruby/pull/332


Related issues

Related to Ruby master - Bug #6862: BigMath.exp negative exponentClosed08/13/2012Actions

Associated revisions

Revision 157dd917
Added by nagachika (Tomoyuki Chikanaga) over 6 years ago

merge revision(s) 41623,41723: [Backport #6862] [Backport #8587]

    * ext/bigdecimal/bigdecimal.c (BigMath_s_exp): Fix for the cases when
      the argument x is not a BigDecimal.
      This change is based on the patch made by Garth Snyder.
      [Fix GH-332] https://github.com/ruby/ruby/pull/332
      This change is based on the patch made by Heesob Park and Garth Snyder.
      [Bug #6862] [ruby-core:47145]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@41733 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 41733
Added by nagachika (Tomoyuki Chikanaga) over 6 years ago

merge revision(s) 41623,41723: [Backport #6862] [Backport #8587]

* ext/bigdecimal/bigdecimal.c (BigMath_s_exp): Fix for the cases when
  the argument x is not a BigDecimal.
  This change is based on the patch made by Garth Snyder.
  [Fix GH-332] https://github.com/ruby/ruby/pull/332
  This change is based on the patch made by Heesob Park and Garth Snyder.
  [Bug #6862] [ruby-core:47145]

History

Updated by nagachika (Tomoyuki Chikanaga) over 6 years ago

  • Status changed from Open to Assigned

https://bugs.ruby-lang.org/issues/6862#change-40133
で Heesob がもっと前からパッチ出してたのに……と訴えているので、ChangeLog に追記しておいたほうがいいかと思うのですがどうでしょう。

Updated by mrkn (Kenta Murata) over 6 years ago

そうですね。あの issue はすっかり見逃していたので、彼には悪いことをしてしまいました。
trunk の ChangeLog には彼の名前を書き加えました。

Updated by nagachika (Tomoyuki Chikanaga) over 6 years ago

ありがとうございます!
一緒にバックポートしておきます。

#4

Updated by nagachika (Tomoyuki Chikanaga) over 6 years ago

  • % Done changed from 0 to 100
  • Status changed from Assigned to Closed

This issue was solved with changeset r41733.
Kenta, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 41623,41723: [Backport #6862] [Backport #8587]

* ext/bigdecimal/bigdecimal.c (BigMath_s_exp): Fix for the cases when
  the argument x is not a BigDecimal.
  This change is based on the patch made by Garth Snyder.
  [Fix GH-332] https://github.com/ruby/ruby/pull/332
  This change is based on the patch made by Heesob Park and Garth Snyder.
  [Bug #6862] [ruby-core:47145]

Also available in: Atom PDF