Project

General

Profile

Actions

Bug #8685

closed

Problems of the example of REXM::Attribute#namespace

Added by ohai (Ippei Obayashi) over 11 years ago. Updated over 11 years ago.

Status:
Closed
Assignee:
Target version:
-
ruby -v:
ruby 2.1.0dev (2013-07-25 trunk 42169) [x86_64-linux]
[ruby-core:56173]

Description

The exmaple of the comment document of REXML::Attribute#namespace has some problems.

  • An old style hash literal is used.
  • The example really does not use EXML::Attribute#namespace
    A patch to fix the example is attached to this ticket.

Files

rexml-attribute-namespace.patch (705 Bytes) rexml-attribute-namespace.patch ohai (Ippei Obayashi), 07/26/2013 01:35 AM

Updated by zzak (zzak _) over 11 years ago

@ohai Thank you! It seems you removed an example for #add_attributes

Why was this removed?

Updated by zzak (zzak _) over 11 years ago

  • Status changed from Open to Assigned

Updated by ohai (Ippei Obayashi) over 11 years ago

zzak (Zachary Scott) wrote:

@ohai Thank you! It seems you removed an example for #add_attributes

Why was this removed?
This is because

  • the example is a part the document of REXM::Attribute#namespace, not a part of REXML::Element#add_attributes
  • REXML::Element#add_namespace is a better way to add a new namespace rather than add_attribute
Actions #4

Updated by zzak (zzak _) over 11 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r42376.
Ippei, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • lib/rexml/attribute.rb: [DOC] Update example for #namespace
    Patch by Ippei Obayashi [Bug #8685] [ruby-core:56173]
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0