Project

General

Profile

Bug #8685

Problems of the example of REXM::Attribute#namespace

Added by ohai (Ippei Obayashi) almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Target version:
-
ruby -v:
ruby 2.1.0dev (2013-07-25 trunk 42169) [x86_64-linux]
[ruby-core:56173]

Description

The exmaple of the comment document of REXML::Attribute#namespace has some problems.

  • An old style hash literal is used.
  • The example really does not use EXML::Attribute#namespace A patch to fix the example is attached to this ticket.
rexml-attribute-namespace.patch (705 Bytes) rexml-attribute-namespace.patch ohai (Ippei Obayashi), 07/26/2013 01:35 AM

Associated revisions

Revision e730b1aa
Added by zzak (Zachary Scott) almost 5 years ago

  • lib/rexml/attribute.rb: [DOC] Update example for #namespace Patch by Ippei Obayashi [Bug #8685]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42376 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 42376
Added by zzak (Zachary Scott) almost 5 years ago

  • lib/rexml/attribute.rb: [DOC] Update example for #namespace Patch by Ippei Obayashi [Bug #8685]

Revision 42376
Added by zzak (Zachary Scott) almost 5 years ago

  • lib/rexml/attribute.rb: [DOC] Update example for #namespace Patch by Ippei Obayashi [Bug #8685]

Revision 42376
Added by zzak (Zachary Scott) almost 5 years ago

  • lib/rexml/attribute.rb: [DOC] Update example for #namespace Patch by Ippei Obayashi [Bug #8685]

Revision 42376
Added by zzak (Zachary Scott) almost 5 years ago

  • lib/rexml/attribute.rb: [DOC] Update example for #namespace Patch by Ippei Obayashi [Bug #8685]

Revision 42376
Added by zzak (Zachary Scott) almost 5 years ago

  • lib/rexml/attribute.rb: [DOC] Update example for #namespace Patch by Ippei Obayashi [Bug #8685]

History

#1 [ruby-core:56175] Updated by zzak (Zachary Scott) almost 5 years ago

ohai (Ippei Obayashi) Thank you! It seems you removed an example for #add_attributes

Why was this removed?

#2 [ruby-core:56176] Updated by zzak (Zachary Scott) almost 5 years ago

  • Status changed from Open to Assigned

#3 [ruby-core:56243] Updated by ohai (Ippei Obayashi) almost 5 years ago

zzak (Zachary Scott) wrote:

ohai (Ippei Obayashi) Thank you! It seems you removed an example for #add_attributes

Why was this removed?
This is because

  • the example is a part the document of REXM::Attribute#namespace, not a part of REXML::Element#add_attributes
  • REXML::Element#add_namespace is a better way to add a new namespace rather than add_attribute

#4 Updated by zzak (Zachary Scott) almost 5 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r42376.
Ippei, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • lib/rexml/attribute.rb: [DOC] Update example for #namespace Patch by Ippei Obayashi [Bug #8685]

Also available in: Atom PDF