Bug #8771

Start does not use proxy configuration form ENV variables

Added by Sam Taylor almost 2 years ago. Updated 12 months ago.

[ruby-core:56525]
Status:Rejected
Priority:Normal
Assignee:Yui NARUSE
ruby -v:2.1.0dev Backport:1.9.3: UNKNOWN, 2.0.0: UNKNOWN

Description

=begin
* Start a fake proxy in a separate window: (({nc -l 8089}))
* (({export http_proxy=http://localhost:8089}))
* (({irb -r net/http}))
* (({Net::HTTP.start('google.com').get('/')}))
* Note that the above http request was not proxied using the environment configuration
* (({Net::HTTP.new('google.com').get('/')})) exhibits the correct behaviour, the proxied HTTP request can be seen in the nc output
=end

378.patch Magnifier - https://github.com/ruby/ruby/pull/378 (3.07 KB) Sam Taylor, 08/11/2013 07:09 AM


Related issues

Related to Ruby trunk - Feature #6546: Net::HTTP to check for HTTP_PROXY environment setting. Closed 06/04/2012

History

#1 Updated by Sam Taylor almost 2 years ago

#2 Updated by Zachary Scott almost 2 years ago

  • Status changed from Open to Assigned

#3 Updated by Yui NARUSE almost 2 years ago

  • Status changed from Assigned to Rejected

It causes that a client can set http_proxy on CGI environments.

see also akr's comment on https://bugs.ruby-lang.org/issues/6546

#4 Updated by Jason Meller 12 months ago

Yui NARUSE wrote:

It causes that a client can set http_proxy on CGI environments.

see also akr's comment on https://bugs.ruby-lang.org/issues/6546

Yui can you take closer look at this bug? The patch seems to set the variable correctly to avoid the CGI issue as defined in https://bugs.ruby-lang.org/issues/6546. I believe this bug is valid and that the page makes the behavior between Net::HTTP.start('google.com').get('/') and Net::HTTP.new('google.com').get('/') consistent when dealing with a proxy set in an environment variable.

Also available in: Atom PDF