Project

General

Profile

Feature #8771

Start does not use proxy configuration form ENV variables

Added by sjltaylor (Sam Taylor) about 4 years ago. Updated 19 days ago.

Status:
Closed
Priority:
Normal
Target version:
[ruby-core:56525]

Description

=begin
* Start a fake proxy in a separate window: (({nc -l 8089}))
* (({export http_proxy=http://localhost:8089}))
* (({irb -r net/http}))
* (({Net::HTTP.start('google.com').get('/')}))
* Note that the above http request was not proxied using the environment configuration
* (({Net::HTTP.new('google.com').get('/')})) exhibits the correct behaviour, the proxied HTTP request can be seen in the nc output
=end

378.patch (3.07 KB) 378.patch https://github.com/ruby/ruby/pull/378 sjltaylor (Sam Taylor), 08/11/2013 07:09 AM

Related issues

Related to Ruby trunk - Feature #6546: Net::HTTP to check for HTTP_PROXY environment setting.Closed2012-06-04
Related to Ruby trunk - Bug #13351: net/http: Net::HTTP.start sets wrong default arg valueClosed

History

#2 [ruby-core:56531] Updated by zzak (Zachary Scott) about 4 years ago

  • Status changed from Open to Assigned

#3 [ruby-core:57246] Updated by naruse (Yui NARUSE) about 4 years ago

  • Status changed from Assigned to Rejected

It causes that a client can set http_proxy on CGI environments.

see also akr's comment on https://bugs.ruby-lang.org/issues/6546

#4 [ruby-core:64352] Updated by terracatta (Jason Meller) about 3 years ago

Yui NARUSE wrote:

It causes that a client can set http_proxy on CGI environments.

see also akr's comment on https://bugs.ruby-lang.org/issues/6546

Yui can you take closer look at this bug? The patch seems to set the variable correctly to avoid the CGI issue as defined in https://bugs.ruby-lang.org/issues/6546. I believe this bug is valid and that the page makes the behavior between Net::HTTP.start('google.com').get('/') and Net::HTTP.new('google.com').get('/') consistent when dealing with a proxy set in an environment variable.

#5 Updated by naruse (Yui NARUSE) 19 days ago

  • Related to Bug #13351: net/http: Net::HTTP.start sets wrong default arg value added

#6 [ruby-core:83042] Updated by naruse (Yui NARUSE) 19 days ago

  • Backport deleted (1.9.3: UNKNOWN, 2.0.0: UNKNOWN)
  • ruby -v deleted (2.1.0dev)
  • Status changed from Rejected to Closed
  • Tracker changed from Bug to Feature

Implemented as r58798

Also available in: Atom PDF