Bug #8837: net/telnet: strange implementation

• Status: Rejected
• Assignee: -
• Target version: -
• ruby -v: ruby 2.0.0p247 (2013-06-27 revision 41674) [x86_64-darwin10.8.0]
• Backport: 2.1: UNKNOWN

[paddor (Patrik Wenger)]

=begin
Net::Telnet#waitfor has IMHO a very strange line. See https://github.com/ruby/ruby/blob/trunk/lib/net/telnet.rb#L586.

As far as I can tell, this line always results in setting (({rest = ""})) due to the regular expression above always matching at the end of (({buf})).

Also, since (({rest})) is set to an empty string right before that, I think this line can be removed.

What's your opinion?

=end

[nobu (Nobuyoshi Nakada)]

Seems that it should be:

             if pt = buf.rindex(/\r\z/no)
               buf, rest = buf[0 ... pt], buf[pt .. -1]
             end

or

             if buf.chomp!("\r")
               rest = "\r"
             end

to me.

[hsbt (Hiroshi SHIBATA)]

• Status changed from Open to Rejected
• Backport changed from 1.9.3: UNKNOWN, 2.0.0: UNKNOWN to 2.1: UNKNOWN

net-telnet has been extracted https://github.com/ruby/net-telnet