Project

General

Profile

Bug #8837

net/telnet: strange implementation

Added by Patrik Wenger almost 3 years ago. Updated almost 3 years ago.

Status:
Open
Priority:
Normal
Assignee:
-
ruby -v:
ruby 2.0.0p247 (2013-06-27 revision 41674) [x86_64-darwin10.8.0]
[ruby-core:56881]

Description

=begin
Net::Telnet#waitfor has IMHO a very strange line. See https://github.com/ruby/ruby/blob/trunk/lib/net/telnet.rb#L586.

As far as I can tell, this line always results in setting (({rest = ""})) due to the regular expression above always matching at the end of (({buf})).

Also, since (({rest})) is set to an empty string right before that, I think this line can be removed.

What's your opinion?

=end

History

#1 [ruby-core:56883] Updated by Nobuyoshi Nakada almost 3 years ago

Seems that it should be:

             if pt = buf.rindex(/\r\z/no)
               buf, rest = buf[0 ... pt], buf[pt .. -1]
             end

or

             if buf.chomp!("\r")
               rest = "\r"
             end

to me.

Also available in: Atom PDF