Bug #8877

OptionParser::Version should not rely on SVN

Added by Hiro Asari 7 months ago. Updated 7 months ago.

[ruby-core:57069]
Status:Closed
Priority:Normal
Assignee:-
Category:-
Target version:-
ruby -v:ruby 2.1.0dev (2013-08-02 trunk 42320) [x86_64-darwin12.4.0] Backport:1.9.3: UNKNOWN, 2.0.0: UNKNOWN

Description

=begin
Currently, (({OptionParser::Version})) is (()) by:

RCSID = %w$Id$[1..-1].each {|s| s.freeze}.freeze
Version = (RCSID[1].split('.').collect {|s| s.to_i}.extend(Comparable).freeze if RCSID[1])

This assumes that before this file is invoked, something preprocesses this file and rewrites (({$Id$})). This is not the case with (({git})).

As a result, if you build from the git clone, you'd get

irb(main):001:0> RUBYDESCRIPTION
=> "ruby 2.1.0dev (2013-08-02 trunk 42320) [x86
64-darwin12.4.0]"
irb(main):002:0> require 'optparse'
=> true
irb(main):003:0> OptionParser::Version
=> nil

While I understand the history of the development process and Ruby core's professed affinity for SVN, but this strikes me as a very bad idea.

=end

Associated revisions

Revision 42889
Added by Nobuyoshi Nakada 7 months ago

optparse.rb: remove $Id$

  • lib/optparse.rb (OptionParser): remove constants depending on $Id$. [Bug #8877]

History

#1 Updated by Nobuyoshi Nakada 7 months ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r42889.
Hiro, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


optparse.rb: remove $Id$

  • lib/optparse.rb (OptionParser): remove constants depending on $Id$. [Bug #8877]

Also available in: Atom PDF