Project

General

Profile

Actions

Bug #9074

closed

Doc promotes inadequate way to sanitize a filename

Added by cphoenix (Chris Phoenix) over 10 years ago. Updated over 10 years ago.

Status:
Closed
Assignee:
Target version:
-
ruby -v:
2.0.0
[ruby-core:58137]

Description

http://www.ruby-doc.org/stdlib-2.0.0/libdoc/drb/rdoc/DRb.html
also http://www.ruby-doc.org/stdlib-1.8.7/libdoc/drb/rdoc/DRb.html

The "server" example for the "Logger" contains these lines:
# make the filename safe, then declare it to be so
fname = name.gsub(/[./]/, "_").untaint

On Windows, backslash is a separator character. The above gsub does not remove backslash.

Updated by zzak (zzak _) over 10 years ago

  • Category set to doc
  • Status changed from Open to Assigned
  • Assignee set to zzak (zzak _)

Thanks for the report!

Actions #2

Updated by zzak (zzak _) over 10 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r43632.
Chris, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • lib/drb/drb.rb: [DOC] promote better windows-safe filename regular
    expression in DRb Logger example. Reported by Chris Pheonix
    [Bug #9074]
Actions

Also available in: Atom PDF

Like0
Like0Like0