Project

General

Profile

Actions

Feature #9841

closed

[RFC] use ihash for fstring implementation

Added by normalperson (Eric Wong) over 10 years ago. Updated almost 7 years ago.

Status:
Rejected
Assignee:
-
Target version:
-
[ruby-core:62596]

Description

This results in ~100K[1] memory savings on start up (with RubyGems
loaded) with no user-visible changes.

While this is not the best example of potential ihash-related memory
savings, there is zero-visible impact related to the loss of hash
ordering from this change.

Per-fstring entry overhead is now 24 bytes per-entry on 64-bit,
half of the previous 48 bytes from st_table_entry_t.

[1] as measured by the time(1) command on eglibc 2.13-38+deb7u1
(Debian 7.0 on x86-64)

Related to Feature #9614

(note: I will have limited Internet access until next week,
free to take your time in reviewing and responding)

Also viewable via git:
http://bogomips.org/ruby.git/patch?id=61c27401ed66 (1/2)
http://bogomips.org/ruby.git/patch?id=67f47a356a7f (2/2)


Files

ihash-fstring-only.mbox (30 Bytes) ihash-fstring-only.mbox normalperson (Eric Wong), 05/15/2014 12:08 AM
ihash-fstring-only.mbox (20.4 KB) ihash-fstring-only.mbox correct mbox file, screwed up original normalperson (Eric Wong), 05/19/2014 10:46 PM

Updated by normalperson (Eric Wong) over 10 years ago

wrote:

This results in ~100K[1] memory savings on start up (with RubyGems
loaded) with no user-visible changes.

Wait, ccan htable is even cheaper in terms of memory usage. It saves
~150K at startup with fstring measured using time(1) on Debian 64-bit
eglibc: http://bogomips.org/ruby.git/patch?id=bddbbfb261b59

Actions #3

Updated by naruse (Yui NARUSE) almost 7 years ago

  • Target version deleted (2.2.0)
Actions #4

Updated by normalperson (Eric Wong) almost 7 years ago

  • Status changed from Open to Rejected
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0