Feature #10173: Remove meaningless ensure

• Status: Closed
• Assignee: -
• Target version: -

[gogotanaka (Kazuki Tanaka)]

I suppose 'empty ensure' like that ↓ has no meaning,

begin
  r.document args
rescue Errno::EACCES => e
  dirname = File.dirname e.message.split("-")[1].strip
  raise Gem::FilePermissionError, dirname
rescue Interrupt => e
  raise e
rescue Exception => ex
  alert_error "While generating documentation for #{@spec.full_name}"
  ui.errs.puts "... MESSAGE:   #{ex}"
  ui.errs.puts "... RDOC args: #{args.join(' ')}"
  ui.backtrace ex
  ui.errs.puts "(continuing with the rest of the installation)"
ensure
end

So I remove that.

[nagachika (Tomoyuki Chikanaga)]

The patch looks good to me.
But rubygems has upstream repository.

https://github.com/rubygems/rubygems/

Please report to it first.

[gogotanaka (Kazuki Tanaka)]

@ Tomoyuki Chikanaga san

Thank you for letting me know.

I have reported to "https://github.com/rubygems/rubygems/" as you said.

https://github.com/rubygems/rubygems/pull/1003

Thanks, gogo.

[hsbt (Hiroshi SHIBATA)]

• Status changed from Open to Closed

I merged latest rubygems at r47582