Project

General

Profile

Bug #10252

[PATCH] digest/rmd160 looks for wrong OpenSSL function

Added by luizluca (Luiz Angelo Daros de Luca) over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
ruby -v:
ruby 2.1.2p95 (2014-05-08 revision 45877) [x86_64-linux-gnu]
[ruby-core:65091]

Description

Hello,

At ext/digest/rmd160/extconf.rb, there is:

OpenSSL.check_func("RMD160_Transform", "openssl/ripemd.h")

However, there is no RMD160_Transform at the header file since ever (see: http://git.openssl.org/gitweb/?p=openssl.git;a=history;f=crypto/ripemd/ripemd.h;h=5942eb61808fe2ccdf9fbe4f3238271e55451567;hb=HEAD)

The correct name should be RIPEMD160_Transform.

The result is that ext/digest/rmd160 never uses OpenSSL implementation.

The attached patch fixes that.

BTW, all hashes that can optionaly use openssl (md5, sha1, sha1 and rmd160) check for xxx_Transform function in extconf.rb
in order to detect that OpenSSL is present. However, they only use xxx_Init, xxx_Update and xxx_Finish.
Shouldn't it check for them instead?


Files

003-digest_rmd160_wrong_name_fix.patch (642 Bytes) 003-digest_rmd160_wrong_name_fix.patch luizluca (Luiz Angelo Daros de Luca), 09/17/2014 06:03 PM

Updated by nobu (Nobuyoshi Nakada) over 5 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

Applied in changeset r47801.


rmd160/extconf.rb: fix function name

  • ext/digest/rmd160/extconf.rb: fix transform function name to check. [ruby-core:65091] [Bug #10252]

Also available in: Atom PDF