Project

General

Profile

Feature #10261

[PATCH] Fix improper test method

Added by gogotanaka (Kazuki Tanaka) over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
[ruby-core:65117]

Description

Right now, a test method TestMath#assert_infinity implement like below,

def assert_infinity(a, *rest)
  rest = ["not infinity: #{a.inspect}"] if rest.empty?
  assert_not_predicate(a, :finite?, *rest)
end

I suppose this is intended to check Float::INFINITY or not,

but Float#finite returns True if the value is not NaN or ┬▒Float::INFINITY.

So I fixed it to check Float::INFINITY or not.

If you have different aim for that, please feel free to tell me.

Thank you. gogo.


Files

test_math_ Fix improper test method.PATCH (443 Bytes) test_math_ Fix improper test method.PATCH gogotanaka (Kazuki Tanaka), 09/18/2014 07:58 PM

Updated by nobu (Nobuyoshi Nakada) over 5 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

Applied in changeset r47635.


test_math.rb: use Float#infinite?

  • test/ruby/test_math.rb (TestMath#assert_infinity): Float#finite? returns true also for NaN, so use Float#infinite? instead. [ruby-core:65117] [Feature #10261]

Also available in: Atom PDF