Project

General

Profile

Backport #10401

Ruby/Tk patch for Tcl/Tk8.6

Added by nagai (Hidetoshi Nagai) about 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
[ruby-dev:48671]

Description

永井@知能.九工大です.

Ruby/Tk を Tcl/Tk8.6 と組み合わせて使えるようにするためのパッチです.
2.1.3 p242 用のパッチとなっています.
適用いただけますと幸いです.

tk-diff-ruby-2.1.3-p242 (17.2 KB) tk-diff-ruby-2.1.3-p242 Tcl/Tk8.6 対応パッチ ( Ruby2.1.3p242 用 ) nagai (Hidetoshi Nagai), 10/19/2014 01:11 PM
tk-diff-ruby-2.1.3-p242.for-SEGV-only (7.04 KB) tk-diff-ruby-2.1.3-p242.for-SEGV-only Tcl/Tk8.6 での SEGV 回避パッチ nagai (Hidetoshi Nagai), 10/23/2014 06:07 PM

Related issues

Related to Ruby trunk - Bug #8000: "require 'tk'" segfaults on 64-bit linux with Tk 8.6Closed

Associated revisions

Revision dd4cf6bb
Added by usa (Usaku NAKAMURA) over 3 years ago

  • ext/tk/extconf.rb: support Tcl/Tk8.6.

  • ext/tk/tcltklib.c, ext/tk/lib/tk.rb: get rid of SEGV with Tcl/Tk8.6.
    [Backport #10401]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@50474 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 50474
Added by usa (Usaku NAKAMURA) over 3 years ago

  • ext/tk/extconf.rb: support Tcl/Tk8.6.

  • ext/tk/tcltklib.c, ext/tk/lib/tk.rb: get rid of SEGV with Tcl/Tk8.6.
    [Backport #10401]

History

#1 [ruby-dev:48676] Updated by usa (Usaku NAKAMURA) about 4 years ago

  • Related to Bug #8000: "require 'tk'" segfaults on 64-bit linux with Tk 8.6 added

#2 [ruby-dev:48697] Updated by nagachika (Tomoyuki Chikanaga) about 4 years ago

  • Status changed from Open to Rejected

安定版ブランチでは基本的に不具合修正のみ行う方針にしています。Tcl/Tk の新しいバージョンのサポートというのは新規機能の一種と考えるのが自然かと思いますので、メンテナンスポリシーに照らして Reject とします。何か適用すべき事情があるようでしたら再openしてください。

#3 [ruby-dev:48698] Updated by nagai (Hidetoshi Nagai) about 4 years ago

では,Tcl/Tk 8.6 と組み合わせた場合の SEGV 回避だけのパッチを添付します.
このパッチでは Ruby/Tk 側での機能追加は一切ありません.
外部ライブラリに依存した拡張において,外部ライブラリのバージョンアップに対して Ruby 側の機能追加なしに新バージョンに対応するのは,
(グレーゾーンかもしれませんが) メンテナンスポリシーに反することではないと思います.

#4 [ruby-dev:48965] Updated by vo.x (Vit Ondruch) over 3 years ago

Can this be applied, please? We need this patch for Fedora [1].

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1181160

#5 [ruby-dev:48966] Updated by usa (Usaku NAKAMURA) over 3 years ago

Thank you for reminding, Vit.

Do you need only tk-diff-ruby-2.1.3-p242.for-SEGV-only ?
If so, I can merge it.

#6 [ruby-dev:48967] Updated by vo.x (Vit Ondruch) over 3 years ago

Usaku NAKAMURA wrote:

Do you need only tk-diff-ruby-2.1.3-p242.for-SEGV-only ?

Yep, that should be enough.

Actually since I noticed this backport ticket with the patch too late, I already applied patch [1] to our package. But these are the same, I just stripped a few additional hunks with DUMPs which seems unimportant.

[1] http://pkgs.fedoraproject.org/cgit/ruby.git/tree/ruby-2.2.0-Support-tcl-tk-8.6.patch?h=f21

#7 Updated by usa (Usaku NAKAMURA) over 3 years ago

  • Status changed from Open to Closed

Applied in changeset r50474.


  • ext/tk/extconf.rb: support Tcl/Tk8.6.

  • ext/tk/tcltklib.c, ext/tk/lib/tk.rb: get rid of SEGV with Tcl/Tk8.6.
    [Backport #10401]

#8 [ruby-dev:48969] Updated by usa (Usaku NAKAMURA) over 3 years ago

merged tk-diff-ruby-2.1.3-p242.for-SEGV-only at r50474.
Thank you, Vit! (and, of course, Nagai-sensei!)

Also available in: Atom PDF