Feature #11229: [PATCH] socket: allow exception-free nonblocking sendmsg/recvmsg

• Status: Closed
• Assignee: matz (Yukihiro Matsumoto)
• Target version: -

[normalperson (Eric Wong)]

As documented before, exceptions are expensive and IO::Wait*able are too
common in socket applications to be the exceptional case. Datagram
sockets deserve the same API which stream sockets are allowed with
read_nonblock and write_nonblock.

Note: this does not offer a performance advantage under optimal
conditions when both ends are equally matched in speed, but it it
does make debug output cleaner by avoiding exceptions whenever
the receiver slows down.

I think I have only one more change I'd like to add for recv/recvmsg* APIs
in the future: destination buffers to reduce GC overhead

[matz (Yukihiro Matsumoto)]

Looks good to me. Go ahead.

Matz.

• Status changed from Open to Closed

Applied in changeset r50910.

---

socket: allow exception-free nonblocking sendmsg/recvmsg

As documented before, exceptions are expensive and IO::Wait*able are too
common in socket applications to be the exceptional case. Datagram
sockets deserve the same API which stream sockets are allowed with
read_nonblock and write_nonblock.

Note: this does not offer a performance advantage under optimal
conditions when both ends are equally matched in speed, but it it
does make debug output cleaner by avoiding exceptions whenever
the receiver slows down.

• ext/socket/ancdata.c (bsock_sendmsg_internal, bsock_recvmsg_internal):
  support "exception: false" kwarg
• ext/socket/init.c (rsock_s_recvfrom_nonblock):
  ditto
• ext/socket/init.c (rsock_s_recvfrom_nonblock): use rsock_opt_false_p
• ext/socket/socket.c (sock_connect_nonblock): ditto
• ext/socket/rubysocket.h (rsock_opt_false_p): new function
• ext/socket/basicsocket.c (bsock_recv_nonblock): update rdoc
• ext/socket/udpsocket.c (udp_recvfrom_nonblock): ditto
• test/socket/test_nonblock.rb: new tests

[ruby-core:69542] [Feature #11229]