Project

General

Profile

Actions

Feature #11358

closed

[PATCH] ARGF.read_nonblock should support `exception: false'

Added by normalperson (Eric Wong) about 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-core:70000]

Description

io.c (argf_read_nonblock): support `exception: false'

This is a preparation for [ruby-core:69892]
("io.c: avoid kwarg parsing in C API")
since I noticed ARGF.read_nonblock did not properly catch up to
the `exception: false' change.

* io.c (argf_read_nonblock): support `exception: false'
  (io_nonblock_eof): new function
  (io_read_nonblock): use io_nonblock_eof
  (argf_getpartial): accept kwargs hash for `exception: false'

* test/ruby/test_argf.rb (test_read_nonblock): new test

Seems like a no brainer, will commit soon

Files

Actions #1

Updated by Anonymous about 6 years ago

  • Status changed from Open to Closed

Applied in changeset r51285.


io.c (argf_read_nonblock): support `exception: false'

This is a preparation for [ruby-core:69892]
("io.c: avoid kwarg parsing in C API")
since I noticed ARGF.read_nonblock did not properly catch up to
the `exception: false' change.

  • io.c (argf_read_nonblock): support exception: false' (io_nonblock_eof): new function (io_read_nonblock): use io_nonblock_eof (argf_getpartial): accept kwargs hash forexception: false'
  • test/ruby/test_argf.rb (test_read_nonblock): new test [ruby-core:70000] [Feature #11358]
  • NEWS: add item for ARGF.read_nonblock
Actions

Also available in: Atom PDF