Feature #11358: [PATCH] ARGF.read_nonblock should support `exception: false'

• Status: Closed
• Assignee: -
• Target version: -

[normalperson (Eric Wong)]

io.c (argf_read_nonblock): support `exception: false'

This is a preparation for [ruby-core:69892]
("io.c: avoid kwarg parsing in C API")
since I noticed ARGF.read_nonblock did not properly catch up to
the `exception: false' change.

* io.c (argf_read_nonblock): support `exception: false'
  (io_nonblock_eof): new function
  (io_read_nonblock): use io_nonblock_eof
  (argf_getpartial): accept kwargs hash for `exception: false'

* test/ruby/test_argf.rb (test_read_nonblock): new test

Seems like a no brainer, will commit soon

• Status changed from Open to Closed

Applied in changeset r51285.

---

io.c (argf_read_nonblock): support `exception: false'

This is a preparation for [ruby-core:69892]
("io.c: avoid kwarg parsing in C API")
since I noticed ARGF.read_nonblock did not properly catch up to
the `exception: false' change.

• io.c (argf_read_nonblock): support exception: false' (io_nonblock_eof): new function (io_read_nonblock): use io_nonblock_eof (argf_getpartial): accept kwargs hash for exception: false'
• test/ruby/test_argf.rb (test_read_nonblock): new test
  [ruby-core:70000] [Feature #11358]
• NEWS: add item for ARGF.read_nonblock