Bug #11787: rb_inspect() should check Encoding.default_internal instead of Encoding.default_external

• Status: Closed
• Assignee: naruse (Yui NARUSE)
• Target version: -
• Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN

[shugo (Shugo Maeda)]

rb_inspect() checks Encoding.default_external even if Encoding.default_internal is specified.

$ cat t.rb
puts "\u3042"
p "\u3042"
$ ruby -E windows-31j:utf-8 t.rb
あ
t.rb:2:in `p': inspected result must be ASCII only or use the default external encoding (Encoding::CompatibilityError)
	from t/t.rb:2:in `<main>'

Encoding.default_internal should be check instead.

[shugo (Shugo Maeda)]

• File 0001-object.c-rb_inspect-check-the-default-internal-encod.patch 0001-object.c-rb_inspect-check-the-default-internal-encod.patch added

Shugo Maeda wrote:

Encoding.default_internal should be check instead.

I've attached a patch.

[naruse (Yui NARUSE)]

Looks good the concept.
Could you rebase and commit it?

[shugo (Shugo Maeda)]

• Status changed from Open to Closed

Applied in changeset r53067.

---

• object.c (rb_inspect): check the default internal encoding as
  String#inspect do.
  [ruby-dev:49415] [Bug #11787]