ThreadError in 2.3 on code that works on 2.2.4
This is my first bug reporting, so I'm sorry if this isn't exactly correct format. I'll update my report accordingly if pointed in the right direction.
I ran into what appears to be a bug while doing a quiz.
I've included the breaking code, the test suite and the description of the quiz as attachments to this bug report.
The following code works fine on Ruby 2.2.4.
class Prime def self.nth(num) error(num) primes = build_primes(num) primes.last end private def build_primes(num) primes =  index = 3 until primes.size == num if example?(index, primes) primes << index end index += 1 end primes end def error(num) unless num > 0 raise ArgumentError end end def example?(index, primes) primes.each do |prime| if index % prime == 0 return false end end true end end
It raises this error in Ruby 2.3.0
ThreadError: deadlock; recursive locking /home/clayton/.rubies/ruby-2.3.0/lib/ruby/2.3.0/singleton.rb:140:in `synchronize' /home/clayton/.rubies/ruby-2.3.0/lib/ruby/2.3.0/singleton.rb:140:in `instance' /home/clayton/.rubies/ruby-2.3.0/lib/ruby/2.3.0/singleton.rb:142:in `block in instance' /home/clayton/.rubies/ruby-2.3.0/lib/ruby/2.3.0/singleton.rb:140:in `synchronize' /home/clayton/.rubies/ruby-2.3.0/lib/ruby/2.3.0/singleton.rb:140:in `instance' /home/clayton/exercism/ruby/nth-prime/nth_prime.rb:3:in `nth' nth_prime_test.rb:28:in `test_first'
If this is expected behavior, I'm sorry in advance for wasting your time.
#1 [ruby-core:72727] Updated by JEG2 (James Gray) over 1 year ago
This is the minimal reproduction I could come up with:
require "forwardable" require "singleton" class Surprise include Singleton class << self extend Forwardable def method_added(method) (class << self; self; end).def_delegator(:instance, method) end end define_method(:new) do |*| fail "Oops" end def self.do_something wrong_level end private def wrong_level end end Surprise.do_something
#3 [ruby-core:75733] Updated by tmornini (Tom Mornini) 11 months ago
James Gray wrote:
The following code works fine on Ruby 2.2.4
It raises this error in Ruby 2.3.0
ThreadError: deadlock; recursive locking
We just saw this same error -- apparently out of nowhere -- on very stable code that utilizes Celluloid while under significant load.
We've never seen this error previously but cannot yet say that it runs fine on 2.2.4 -- though we do have a strong belief that it runs well under 1.9.3.
We'll try it under 2.2.4 and report back.
#6 [ruby-core:75877] Updated by noahgibbs (Noah Gibbs) 11 months ago
The error is occurring in Singleton's instance method, which is mutex-protected.
Using the supplied example code, git-bisect points to this Ruby commit as the problem:
commit d2487ed47587ec1cd1b456068e0af3ea0b39596d Author: marcandre <marcandre@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> Date: Fri May 22 13:36:39 2015 +0000 * lib/prime.rb: Remove obsolete Prime.new patch by Ajay Kumar. [Fixes GH-891] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50604 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
And that's where Prime switched from using a @the_instance member variable to using Singleton to track its instance.
So it looks like this code never worked with Prime as a Singleton.
#7 [ruby-core:75878] Updated by noahgibbs (Noah Gibbs) 11 months ago
Okay, Prime removed its .new() method. Singleton appears to depend on .new(). It's getting the recursive synch because the deprecated new() is calling instance(), so it would recurse infinitely. But instead, it tries to grab its own mutex and dies that way.
#8 [ruby-core:75902] Updated by marcandre (Marc-Andre Lafortune) 11 months ago
So, a minimal example is:
require 'prime' class Prime def new end end # access instance, directly or indirectly via a delegated class method Prime.prime?(42) # ThreadError: deadlock
It's easy to circumvent by calling
Prime.instance before defining
new, either directly or indirectly (via any delegated class method like
prime library should instantiate the singleton on load? That would resolve the issue at hand.
I am a bit baffled by what is the intent behind defining an instance method called
#9 [ruby-core:75903] Updated by noahgibbs (Noah Gibbs) 11 months ago
Marc-Andre: this is happening in code that doesn't define new or call instance() directly -- the supplied sample code doesn't do either of those. Instead, methods called on Prime are forwarded to its instance. If the instance doesn't exist, they try to create it using new. Prime.new doesn't work -- it calls .instance() again, recursing and trying to grab the mutex again.
Just calling Prime.instance() first wouldn't help. You'd have to set the instance variable of Prime (the one Singleton uses) manually in some way to avoid calling Prime.new, which does the wrong thing.
Part of the problem is that Prime.new is an old deprecated interface that users used to use and now shouldn't.
The test code is just calling Prime.nth() and failing.
#10 [ruby-core:75904] Updated by marcandre (Marc-Andre Lafortune) 11 months ago
- Assignee set to marcandre (Marc-Andre Lafortune)
this is happening in code that doesn't define new
I'm sorry if I'm missing something, but could you please provide such code?
Lines 12-15 of
nth_prime_test.rb defines an instance method called
new, and James also defines
new in his code.
Just calling Prime.instance() first wouldn't help
Did you actually try? Inserting
nth_prime_test.rb after the require doesn't produce the error
Part of the problem is that Prime.new is an old deprecated interface that users used to use and now shouldn't
FWIW, Prime.new was deprecated in Ruby 1.9.0, more than 7 years ago. Are there examples of users still calling it?