Project

General

Profile

Actions

Feature #11965

closed

provide default basename parameter Tempfile.create

Added by ksss (Yuki Kurihara) over 8 years ago. Updated over 7 years ago.

Status:
Closed
Target version:
-
[ruby-core:72747]

Description

Tempfile.new have default basename from 2.3.0

https://github.com/ruby/ruby/commit/05c108cdba62545bb50616726f0b7261cb89ad4e

So, I propose that Tempfile.create also set default basename.

ref https://github.com/ruby/ruby/pull/523


Files

tempfile-create-basename.patch (942 Bytes) tempfile-create-basename.patch ksss (Yuki Kurihara), 01/07/2016 04:57 AM

Updated by ksss (Yuki Kurihara) over 8 years ago

  • Description updated (diff)
Actions #2

Updated by sonots (Naotoshi Seo) over 7 years ago

  • Status changed from Open to Closed

Applied in changeset r56251.


  • lib/tempfile.rb: provide default basename parameter
    for Tempfile.create. [Feature #11965] Patch by Yuki Kurihara
  • test/test_tempfile.rb: ditto.
Actions #3

Updated by sonots (Naotoshi Seo) over 7 years ago

  • Assignee set to sonots (Naotoshi Seo)

I also wanted to have default basename parameter for Tempfile.create as Tempfile.new, and found this issue.
I believe nobody have objections to this change, so committed to trunk.

If anyone has any objections, please let me know.
Thanks for the patch!

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0