Project

General

Profile

Feature #11965

provide default basename parameter Tempfile.create

Added by ksss (Yuki Kurihara) over 1 year ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Target version:
-
[ruby-core:72747]

Description

Tempfile.new have default basename from 2.3.0

https://github.com/ruby/ruby/commit/05c108cdba62545bb50616726f0b7261cb89ad4e

So, I propose that Tempfile.create also set default basename.

ref https://github.com/ruby/ruby/pull/523

tempfile-create-basename.patch View (942 Bytes) ksss (Yuki Kurihara), 01/07/2016 04:57 AM

Associated revisions

Revision 56251
Added by sonots (Naotoshi Seo) 9 months ago

  • lib/tempfile.rb: provide default basename parameter for Tempfile.create. [Feature #11965] Patch by Yuki Kurihara
  • test/test_tempfile.rb: ditto.

Revision 56251
Added by sonots (Naotoshi Seo) 9 months ago

  • lib/tempfile.rb: provide default basename parameter for Tempfile.create. [Feature #11965] Patch by Yuki Kurihara
  • test/test_tempfile.rb: ditto.

History

#1 [ruby-core:72748] Updated by ksss (Yuki Kurihara) over 1 year ago

  • Description updated (diff)

#2 Updated by sonots (Naotoshi Seo) 9 months ago

  • Status changed from Open to Closed

Applied in changeset r56251.


  • lib/tempfile.rb: provide default basename parameter for Tempfile.create. [Feature #11965] Patch by Yuki Kurihara
  • test/test_tempfile.rb: ditto.

#3 Updated by sonots (Naotoshi Seo) 9 months ago

  • Assignee set to sonots (Naotoshi Seo)

I also wanted to have default basename parameter for Tempfile.create as Tempfile.new, and found this issue.
I believe nobody have objections to this change, so committed to trunk.

If anyone has any objections, please let me know.
Thanks for the patch!

Also available in: Atom PDF